This repository was archived by the owner on May 21, 2019. It is now read-only.
Fix FunctionCallTag registering in iOS and support to manually refreshing the container#316
Merged
Conversation
Support Function Call tags in both environments.
… RCTGoogleTagManagerBridge itself as the emitter Fix missing function name not being provided to registered function call tag handler in iOS Rename JS helper module to FunctionCallTagHandler to better conform to actual GTM namings.
…rtToWritable class
…lled on an undefined object. It is now possible to manually request the container to be refreshed.
Member
|
Thanks for the PR @farzadshafiee. I'll have a look! |
cbrevik
approved these changes
Mar 15, 2019
cbrevik
left a comment
cbrevik
left a comment
Member
There was a problem hiding this comment.
Awesome, this looks good to me, thanks @farzadshafiee!
Member
|
This has been released as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an error in
FunctionCallTagHandlerIOS.tsmodule which caused the app to to crash due to a method call on an uninitialized variable.It also adds
refreshContainermethod so that developers can control the refresh rate of the contianer. @cbrevik, I did not document this method in the README file because I was not able to see it working properly. The native module was acting up and always throwing too many request error, and the new variables that we defined in the GTM console never became available, but the bridge works as expected, since these logs come form the native module not the bridge itself. If you decide to document it in the README, make note of that (per Google's own words) this method should not be called more than once per each 15 minutes.