fix: improve LessThan and adds assert#48
Merged
jbaylina merged 1 commit intoAug 24, 2020
Conversation
Member
|
Please add the assert. |
Contributor
Author
|
It's there! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LessThanat the moment usesNum2Bits(2*n+1), while it practically needs just an extra bit, so it could usen+1(h/t @jbaylina for noticing that). This is true because the inputs are assumed to be less than or equal tonbits, and so the difference ofaandb+2^n, ifa < b, will have then+1bit off, which is what we check.Additionally,
nmust be<= 252, sinceNum2Bitscan have multiple correct witnesses fornum bits >= 254.