Fix: #7. Add JSON Schema media types #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregsdennis
reviewed
Feb 15, 2022
ioggstream
reviewed
Feb 17, 2022
ioggstream
reviewed
Feb 17, 2022
ioggstream
reviewed
Feb 17, 2022
ioggstream
reviewed
Feb 17, 2022
ioggstream
reviewed
Feb 17, 2022
ioggstream
reviewed
Feb 17, 2022
ioggstream
changed the title
Closed
jdesrosiers
force-pushed
the
add-jsonschema
branch
from
eb3cc40 to
4d13035
Compare
Contributor
Author
|
Improvements based on comments have been pushed. |
ioggstream
approved these changes
Feb 21, 2022
Collaborator
ioggstream
left a comment
ioggstream
left a comment
There was a problem hiding this comment.
LGTM! Thanks @jdesrosiers
This was referenced Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7
This adds the
application/schema+jsonand `application/schema-instance+json media types. I felt that there was too much I wanted to add to #14, so I created an alternate PR. The idea is to define all the media-type specific stuff as loosely as is convenient, define the process for determining the dialect of the schema, and then defer all other semantics to be defined by the dialect. All of this came from the 2020-12 specification with some editing.Tagging the active JSON Schema spec contributors for visibility: @Relequestual @karenetheridge @gregsdennis @Julian