Fix Set-TfsWorkItem Fields parameter error by using actual work item ID (#246)

Copilot · igoravl · web-flow · commit 9e096ed1580d · 2025-06-05T11:59:41.000-03:00
* Initial plan for issue

* Fix Set-TfsWorkItem Fields parameter issue by using actual work item ID

Co-authored-by: igoravl &lt;725797+igoravl@users.noreply.github.com&gt;

* Add support for version "20"

* Update tests

* Update release notes

* Fixes double-confirmation in Remove-TfsTeamProject

* Add missing ShouldProcess support

* Update release notes

---------

Co-authored-by: copilot-swe-agent[bot] &lt;198982749+Copilot@users.noreply.github.com&gt;
Co-authored-by: igoravl &lt;725797+igoravl@users.noreply.github.com&gt;
Co-authored-by: Igor Abade &lt;igoravl@gmail.com&gt;
diff --git a/CSharp/TfsCmdlets/Cmdlets/TeamProject/RemoveTeamProject.cs b/CSharp/TfsCmdlets/Cmdlets/TeamProject/RemoveTeamProject.cs
@@ -49,11 +49,11 @@ protected override IEnumerable Run()
             {
                 if (!PowerShell.ShouldProcess($"[Organization: {tpc.DisplayName}]/[Project: {tp.Name}]", "Delete team project")) continue;
 
-                if (!force && !PowerShell.ShouldContinue($"Are you sure you want to delete team project '{tp.Name}'?")) continue;
+                if (!(force || PowerShell.ShouldContinue($"Are you sure you want to delete team project '{tp.Name}'?"))) continue;
 
-                if (hard && !PowerShell.ShouldContinue(
+                if (hard && !(force || PowerShell.ShouldContinue(
                     "You are using the -Hard switch. The team project deletion is IRREVERSIBLE " +
-                    $"and may cause DATA LOSS. Are you sure you want to proceed with deleting team project '{tp.Name}'")) continue;
+                    $"and may cause DATA LOSS. Are you sure you want to proceed with deleting team project '{tp.Name}'"))) continue;
 
                 var method = hard ? "Hard" : "Soft";
 
diff --git a/CSharp/TfsCmdlets/Cmdlets/WorkItem/SetWorkItem.cs b/CSharp/TfsCmdlets/Cmdlets/WorkItem/SetWorkItem.cs
@@ -154,6 +154,13 @@ protected override IEnumerable Run()
         {
             foreach (var wi in Items)
             {
+                if(!PowerShell.ShouldProcess(
+                    $"Work item {wi.Id} (\"{wi.Fields["System.Title"] ?? "No title"}\")",
+                    "Update work item"))
+                {
+                    continue;
+                }
+
                 var result = Client.UpdateWorkItemAsync(Builder.GetJson(wi), (int)wi.Id, false, BypassRules, SuppressNotifications)
                     .GetResult("Error updating work item");
 
diff --git a/CSharp/TfsCmdlets/Services/Impl/TfsVersionTableImpl.cs b/CSharp/TfsCmdlets/Services/Impl/TfsVersionTableImpl.cs
@@ -205,6 +205,7 @@ public bool IsMajorVersion(int majorVersion)
             [17] = 2019,
             [18] = 2020,
             [19] = 2022,
+            [20] = 2022,
         };
     }
 }
diff --git a/CSharp/TfsCmdlets/Services/Impl/WorkItemPatchBuilderImpl.cs b/CSharp/TfsCmdlets/Services/Impl/WorkItemPatchBuilderImpl.cs
@@ -36,7 +36,7 @@ public JsonPatchDocument GetJson(WebApiWorkItem wi)
 
             if (fields != null && fields.Count > 0)
             {
-                var wit = Data.GetItem<WebApiWorkItemType>(new { Type = wi.Fields["System.WorkItemType"], WorkItem = 0, Project = projectName });
+                var wit = Data.GetItem<WebApiWorkItemType>(new { Type = wi.Fields["System.WorkItemType"], WorkItem = wi.Id, Project = projectName });
                 patch.AddRange(ParseFields(fields, wit, projectName, workItemType));
             }
 
diff --git a/Docs/ReleaseNotes/2.9.1.md b/Docs/ReleaseNotes/2.9.1.md
@@ -0,0 +1,11 @@
+# TfsCmdlets Release Notes
+
+## Version 2.9.1 (_05/Jun/2025_)
+
+This release fixes a critical bug in Set-TfsWorkItem, among other improvements.
+
+## Fixes
+
+- **`Get-TfsVersion`**: Adds support for Azure DevOps Services version "20" (currently mapped to 2022)
+- **`Remove-TfsTeamProject`**: Removes a double-confirmation prompt when using the `-Hard` switch, simplifying the deletion process
+- **`Set-TfsWorkItem`**: Fixed an issue where the actual work item ID wasn't being used when retrieving work item type information, causing some field updates to fail
diff --git a/PS/_Tests/RestApi/InvokeTfsRestApi.Tests.ps1 b/PS/_Tests/RestApi/InvokeTfsRestApi.Tests.ps1
@@ -16,15 +16,15 @@ Describe (($MyInvocation.MyCommand.Name -split '\.')[-3]) {
             | ForEach-Object { $_.ExtensionName } `
             | Sort-Object `
             | Select-Object -First 3 `
-            | Should -Be @('AdvancedSecurity', 'Aex Code Mapper', 'Aex platform')
+            | Should -Be @('AdvancedSecurity', 'AdvancedSecurity Alerts', 'Aex Code Mapper')
         }
 
         It 'Should call multiple alternates hosts in sequence' {
             Invoke-TfsRestApi '/_apis/extensionmanagement/installedextensions' -UseHost 'extmgmt.dev.azure.com' -ApiVersion '6.1' `
             | ForEach-Object { $_.ExtensionName } `
             | Sort-Object `
             | Select-Object -First 3 `
-            | Should -Be @('AdvancedSecurity', 'Aex Code Mapper', 'Aex platform')
+            | Should -Be @('AdvancedSecurity', 'AdvancedSecurity Alerts', 'Aex Code Mapper')
 
             Invoke-TfsRestApi 'GET https://vsrm.dev.azure.com/{organization}/{project}/_apis/release/definitions?api-version=6.1' -Project $tfsProject `
             | ForEach-Object { $_.name } `
diff --git a/PS/_Tests/Team/TeamAdmin/GetTfsTeamAdmin.Tests.ps1 b/PS/_Tests/Team/TeamAdmin/GetTfsTeamAdmin.Tests.ps1
@@ -13,28 +13,28 @@ Describe (($MyInvocation.MyCommand.Name -split '\.')[-3]) {
         It 'Should return all team admins' {
             $result = Get-TfsTeamAdmin -Project $tfsProject -Team "$tfsProject Team"
             $result | Should -BeOfType 'Microsoft.VisualStudio.Services.Identity.Identity'
-            $result.DisplayName | Sort-Object | Should -Be @('Igor Abade (T-Shooter)')
+            $result.DisplayName | Sort-Object | Should -Be @('Igor Abade')
         }
 
         It 'Should return a single team admin by name' {
-            $result = Get-TfsTeamAdmin -Admin 'Igor Abade (T-Shooter)' -Project $tfsProject -Team "$tfsProject Team"
+            $result = Get-TfsTeamAdmin -Admin 'Igor Abade' -Project $tfsProject -Team "$tfsProject Team"
             $result | Should -BeOfType 'Microsoft.VisualStudio.Services.Identity.Identity'
-            $result.DisplayName | Should -Be 'Igor Abade (T-Shooter)'
+            $result.DisplayName | Should -Be 'Igor Abade'
         }
 
         It 'Should return a single team admin by email' {
             $result = Get-TfsTeamAdmin -Admin 'igor@tshooter.com.br' -Project $tfsProject -Team "$tfsProject Team"
             $result | Should -BeOfType 'Microsoft.VisualStudio.Services.Identity.Identity'
-            $result.DisplayName | Should -Be 'Igor Abade (T-Shooter)'
+            $result.DisplayName | Should -Be 'Igor Abade'
         }
 
         It 'Should support wildcards' {
             $result = Get-TfsTeamAdmin -Project $tfsProject -Team "$tfsProject Team" -Admin 'Igor A*'
             $result | Should -BeOfType 'Microsoft.VisualStudio.Services.Identity.Identity'
-            $result.DisplayName | Should -Be 'Igor Abade (T-Shooter)'
+            $result.DisplayName | Should -Be 'Igor Abade'
             $result = Get-TfsTeamAdmin -Project $tfsProject -Team "$tfsProject Team" -Admin 'igor@*'
             $result | Should -BeOfType 'Microsoft.VisualStudio.Services.Identity.Identity'
-            $result.DisplayName | Should -Be 'Igor Abade (T-Shooter)'
+            $result.DisplayName | Should -Be 'Igor Abade'
         }
     } 
 }
diff --git a/PS/_Tests/Team/TeamMember/GetTfsTeamMember.Tests.ps1 b/PS/_Tests/Team/TeamMember/GetTfsTeamMember.Tests.ps1
@@ -13,28 +13,28 @@ Describe (($MyInvocation.MyCommand.Name -split '\.')[-3]) {
         It 'Should return all team members' {
             $result = Get-TfsTeamMember -Project $tfsProject -Team "$tfsProject Team"
             $result | Should -BeOfType 'Microsoft.VisualStudio.Services.Identity.Identity'
-            $result.DisplayName | Sort-Object | Should -Be @('Brian Keller', 'Igor Abade (T-Shooter)')
+            $result.DisplayName | Sort-Object | Should -Be @('Brian Keller', 'Igor Abade')
         }
 
         It 'Should return a single team member by name' {
-            $result = Get-TfsTeamMember -Member 'Igor Abade (T-Shooter)' -Project $tfsProject -Team "$tfsProject Team"
+            $result = Get-TfsTeamMember -Member 'Igor Abade' -Project $tfsProject -Team "$tfsProject Team"
             $result | Should -BeOfType 'Microsoft.VisualStudio.Services.Identity.Identity'
-            $result.DisplayName | Should -Be 'Igor Abade (T-Shooter)'
+            $result.DisplayName | Should -Be 'Igor Abade'
         }
 
         It 'Should return a single team member by email' {
             $result = Get-TfsTeamMember -Member 'igor@tshooter.com.br' -Project $tfsProject -Team "$tfsProject Team"
             $result | Should -BeOfType 'Microsoft.VisualStudio.Services.Identity.Identity'
-            $result.DisplayName | Should -Be 'Igor Abade (T-Shooter)'
+            $result.DisplayName | Should -Be 'Igor Abade'
         }
 
         It 'Should support wildcards' {
             $result = Get-TfsTeamMember -Project $tfsProject -Team "$tfsProject Team" -Member 'Igor A*'
             $result | Should -BeOfType 'Microsoft.VisualStudio.Services.Identity.Identity'
-            $result.DisplayName | Should -Be 'Igor Abade (T-Shooter)'
+            $result.DisplayName | Should -Be 'Igor Abade'
             $result = Get-TfsTeamMember -Project $tfsProject -Team "$tfsProject Team" -Member 'igor@*'
             $result | Should -BeOfType 'Microsoft.VisualStudio.Services.Identity.Identity'
-            $result.DisplayName | Should -Be 'Igor Abade (T-Shooter)'
+            $result.DisplayName | Should -Be 'Igor Abade'
         }
     } 
 }
diff --git a/PS/_Tests/TeamProject/Member/GetTfsTeamProjectMember.Tests.ps1 b/PS/_Tests/TeamProject/Member/GetTfsTeamProjectMember.Tests.ps1
@@ -13,19 +13,19 @@ Describe (($MyInvocation.MyCommand.Name -split '\.')[-3]) {
         It 'Should return all members' {
             $result = Get-TfsTeamProjectMember -Project $tfsProject
             $result | Should -BeOfType 'TfsCmdlets.Models.TeamProjectMember'
-            $result.Name | Sort-Object | Should -Be @('Brian Keller', 'Igor Abade (T-Shooter)')
+            $result.Name | Sort-Object | Should -Be @('Brian Keller', 'Igor Abade')
         }
 
         It 'Should return a single member by name' {
-            $result = Get-TfsTeamProjectMember -Member 'Igor Abade (T-Shooter)' -Project $tfsProject
+            $result = Get-TfsTeamProjectMember -Member 'Igor Abade' -Project $tfsProject
             $result | Should -BeOfType 'TfsCmdlets.Models.TeamProjectMember'
-            $result.Name | Should -Be 'Igor Abade (T-Shooter)'
+            $result.Name | Should -Be 'Igor Abade'
         }
 
         It 'Should return a single member by email' {
             $result = Get-TfsTeamProjectMember -Member 'igor@tshooter.com.br' -Project $tfsProject
             $result | Should -BeOfType 'TfsCmdlets.Models.TeamProjectMember'
-            $result.Name | Should -Be 'Igor Abade (T-Shooter)'
+            $result.Name | Should -Be 'Igor Abade'
         }
 
         It 'Should support wildcards' {
@@ -38,9 +38,9 @@ Describe (($MyInvocation.MyCommand.Name -split '\.')[-3]) {
         }
 
         It 'Should return as identity' {
-            $result = Get-TfsTeamProjectMember 'Igor Abade (T-Shooter)' -Project $tfsProject -AsIdentity
+            $result = Get-TfsTeamProjectMember 'Igor Abade' -Project $tfsProject -AsIdentity
             $result | Should -BeOfType 'Microsoft.VisualStudio.Services.Identity.Identity'
-            $result.DisplayName | Should -Be 'Igor Abade (T-Shooter)'
+            $result.DisplayName | Should -Be 'Igor Abade'
         }
     } 
 }
diff --git a/RELEASENOTES.md b/RELEASENOTES.md
@@ -1,36 +1,23 @@
 # TfsCmdlets Release Notes
 
-## Version 2.9.0 (15/Aug/2024_)
+## Version 2.9.1 (_05/Jun/2025_)
 
-This release adds new process-related cmdlets along with some fixes, enhancements and a couple minor but potentially breaking changes.
-
-## New cmdlets
-
-- **`Get-ProcessFieldDefinition`**: Gets information from one or more organization-wide work item fields
-- **`New-ProcessFieldDefinition`**: Creates a new organization-wide work item field
-- **`Remove-ProcessFieldDefinition`**: Removes an organization-wide work item field
+This release fixes a critical bug in Set-TfsWorkItem, among other improvements.
 
 ## Fixes
 
-- **`Get-TfsArtifact`**: Fixed an issue where it wouldn't list deleted packages.
-- **`Get-TfsArtifactFeed`**: Fixed an issue where it would ignore the -Project argument and thus not filter feeds by project.
-- **`Get-TfsWorkItemTag`**: Fixed an issue where it would fail when given a list of tags as input.
-- **`Get-TfsWorkItemType`**: Fixed an issue where it would throw a "Parameter count mismatch" error when trying to get the work item type of a given work item.
-
-## Changes and enhancements
-
-- **`Get-TfsGitBranch`**: Added a new `-Compare` argument to  to get the "Compare" (base) branch of a given repository.
-- **`Connect-TfsTeamProjectCollection`, `Connect-TfsOrganization`**: Now it throws an error when trying to connect with invalid credentials instead of silently going into "anonymous mode". That help preventing subtle script errors where the lack of authorization would only be noticed later in the script, when trying to actually perform some command that required valid credentials. Now you get the warning that something is wrong as early in the script as possible.
-
-### Breaking changes
-
-- **`Get-TfsGitBranch`**: `-Repository` parameter is now mandatory. This is to reduce the ambiguity of the command when omitting that argument. Scripts that rely on the old behavior may need to be updated.
-- **`Get-TfsGitBranchPolicy`**: Both `-Branch` and `-Repository` parameters are now mandatory. This is to reduce the ambiguity of the command when omitting those arguments. Scripts that rely on the old behavior may need to be updated.
+- **`Get-TfsVersion`**: Adds support for Azure DevOps Services version "20" (currently mapped to 2022)
+- **`Remove-TfsTeamProject`**: Removes a double-confirmation prompt when using the `-Hard` switch, simplifying the deletion process
+- **`Set-TfsWorkItem`**: Fixed an issue where the actual work item ID wasn't being used when retrieving work item type information, causing some field updates to fail
 
 -----------------------
 
 ## Previous Versions
 
+## Version 2.9.0 (_15/Aug/2024_)
+
+See release notes [here](Docs/ReleaseNotes/2.9.0.md).
+
 ## Version 2.8.2 (_24/Jul/2024_)
 
 See release notes [here](Docs/ReleaseNotes/2.8.2.md).

Original file line number	Diff line number	Diff line change
`@@ -154,6 +154,13 @@ protected override IEnumerable Run()`
`154`	`154`	`{`
`155`	`155`	`foreach (var wi in Items)`
`156`	`156`	`{`
	`157`	`+ if(!PowerShell.ShouldProcess(`
	`158`	`+ $"Work item {wi.Id} (\"{wi.Fields["System.Title"] ?? "No title"}\")",`
	`159`	`+ "Update work item"))`
	`160`	`+ {`
	`161`	`+ continue;`
	`162`	`+ }`
	`163`	`+`
`157`	`164`	`var result = Client.UpdateWorkItemAsync(Builder.GetJson(wi), (int)wi.Id, false, BypassRules, SuppressNotifications)`
`158`	`165`	`.GetResult("Error updating work item");`
`159`	`166`
Original file line number	Diff line number	Diff line change
`@@ -205,6 +205,7 @@ public bool IsMajorVersion(int majorVersion)`
`205`	`205`	`[17] = 2019,`
`206`	`206`	`[18] = 2020,`
`207`	`207`	`[19] = 2022,`
	`208`	`+ [20] = 2022,`
`208`	`209`	`};`
`209`	`210`	`}`
`210`	`211`	`}`
Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ public JsonPatchDocument GetJson(WebApiWorkItem wi)`
`36`	`36`
`37`	`37`	`if (fields != null && fields.Count > 0)`
`38`	`38`	`{`
`39`		`- var wit = Data.GetItem<WebApiWorkItemType>(new { Type = wi.Fields["System.WorkItemType"], WorkItem = 0, Project = projectName });`
	`39`	`+ var wit = Data.GetItem<WebApiWorkItemType>(new { Type = wi.Fields["System.WorkItemType"], WorkItem = wi.Id, Project = projectName });`
`40`	`40`	`patch.AddRange(ParseFields(fields, wit, projectName, workItemType));`
`41`	`41`	`}`
`42`	`42`
Original file line number	Diff line number	Diff line change
`@@ -13,28 +13,28 @@ Describe (($MyInvocation.MyCommand.Name -split '\.')[-3]) {`
`13`	`13`	`It 'Should return all team admins' {`
`14`	`14`	`$result = Get-TfsTeamAdmin -Project $tfsProject -Team "$tfsProject Team"`
`15`	`15`	`$result \| Should -BeOfType 'Microsoft.VisualStudio.Services.Identity.Identity'`
`16`		`- $result.DisplayName \| Sort-Object \| Should -Be @('Igor Abade (T-Shooter)')`
	`16`	`+ $result.DisplayName \| Sort-Object \| Should -Be @('Igor Abade')`
`17`	`17`	`}`
`18`	`18`
`19`	`19`	`It 'Should return a single team admin by name' {`
`20`		`- $result = Get-TfsTeamAdmin -Admin 'Igor Abade (T-Shooter)' -Project $tfsProject -Team "$tfsProject Team"`
	`20`	`+ $result = Get-TfsTeamAdmin -Admin 'Igor Abade' -Project $tfsProject -Team "$tfsProject Team"`
`21`	`21`	`$result \| Should -BeOfType 'Microsoft.VisualStudio.Services.Identity.Identity'`
`22`		`- $result.DisplayName \| Should -Be 'Igor Abade (T-Shooter)'`
	`22`	`+ $result.DisplayName \| Should -Be 'Igor Abade'`
`23`	`23`	`}`
`24`	`24`
`25`	`25`	`It 'Should return a single team admin by email' {`
`26`	`26`	`$result = Get-TfsTeamAdmin -Admin '[email protected]' -Project $tfsProject -Team "$tfsProject Team"`
`27`	`27`	`$result \| Should -BeOfType 'Microsoft.VisualStudio.Services.Identity.Identity'`
`28`		`- $result.DisplayName \| Should -Be 'Igor Abade (T-Shooter)'`
	`28`	`+ $result.DisplayName \| Should -Be 'Igor Abade'`
`29`	`29`	`}`
`30`	`30`
`31`	`31`	`It 'Should support wildcards' {`
`32`	`32`	`$result = Get-TfsTeamAdmin -Project $tfsProject -Team "$tfsProject Team" -Admin 'Igor A*'`
`33`	`33`	`$result \| Should -BeOfType 'Microsoft.VisualStudio.Services.Identity.Identity'`
`34`		`- $result.DisplayName \| Should -Be 'Igor Abade (T-Shooter)'`
	`34`	`+ $result.DisplayName \| Should -Be 'Igor Abade'`
`35`	`35`	`$result = Get-TfsTeamAdmin -Project $tfsProject -Team "$tfsProject Team" -Admin 'igor@*'`
`36`	`36`	`$result \| Should -BeOfType 'Microsoft.VisualStudio.Services.Identity.Identity'`
`37`		`- $result.DisplayName \| Should -Be 'Igor Abade (T-Shooter)'`
	`37`	`+ $result.DisplayName \| Should -Be 'Igor Abade'`
`38`	`38`	`}`
`39`	`39`	`}`
`40`	`40`	`}`
Original file line number	Diff line number	Diff line change
`@@ -13,19 +13,19 @@ Describe (($MyInvocation.MyCommand.Name -split '\.')[-3]) {`
`13`	`13`	`It 'Should return all members' {`
`14`	`14`	`$result = Get-TfsTeamProjectMember -Project $tfsProject`
`15`	`15`	`$result \| Should -BeOfType 'TfsCmdlets.Models.TeamProjectMember'`
`16`		`- $result.Name \| Sort-Object \| Should -Be @('Brian Keller', 'Igor Abade (T-Shooter)')`
	`16`	`+ $result.Name \| Sort-Object \| Should -Be @('Brian Keller', 'Igor Abade')`
`17`	`17`	`}`
`18`	`18`
`19`	`19`	`It 'Should return a single member by name' {`
`20`		`- $result = Get-TfsTeamProjectMember -Member 'Igor Abade (T-Shooter)' -Project $tfsProject`
	`20`	`+ $result = Get-TfsTeamProjectMember -Member 'Igor Abade' -Project $tfsProject`
`21`	`21`	`$result \| Should -BeOfType 'TfsCmdlets.Models.TeamProjectMember'`
`22`		`- $result.Name \| Should -Be 'Igor Abade (T-Shooter)'`
	`22`	`+ $result.Name \| Should -Be 'Igor Abade'`
`23`	`23`	`}`
`24`	`24`
`25`	`25`	`It 'Should return a single member by email' {`
`26`	`26`	`$result = Get-TfsTeamProjectMember -Member '[email protected]' -Project $tfsProject`
`27`	`27`	`$result \| Should -BeOfType 'TfsCmdlets.Models.TeamProjectMember'`
`28`		`- $result.Name \| Should -Be 'Igor Abade (T-Shooter)'`
	`28`	`+ $result.Name \| Should -Be 'Igor Abade'`
`29`	`29`	`}`
`30`	`30`
`31`	`31`	`It 'Should support wildcards' {`
`@@ -38,9 +38,9 @@ Describe (($MyInvocation.MyCommand.Name -split '\.')[-3]) {`
`38`	`38`	`}`
`39`	`39`
`40`	`40`	`It 'Should return as identity' {`
`41`		`- $result = Get-TfsTeamProjectMember 'Igor Abade (T-Shooter)' -Project $tfsProject -AsIdentity`
	`41`	`+ $result = Get-TfsTeamProjectMember 'Igor Abade' -Project $tfsProject -AsIdentity`
`42`	`42`	`$result \| Should -BeOfType 'Microsoft.VisualStudio.Services.Identity.Identity'`
`43`		`- $result.DisplayName \| Should -Be 'Igor Abade (T-Shooter)'`
	`43`	`+ $result.DisplayName \| Should -Be 'Igor Abade'`
`44`	`44`	`}`
`45`	`45`	`}`
`46`	`46`	`}`