Fix Set-TfsWorkItem Fields parameter error by using actual work item ID

[Copilot]

Problem

The Set-TfsWorkItem cmdlet was failing when using the -Fields parameter with the error:

Set-TfsWorkItem: Error getting work items (You must pass in a set of valid work item Ids to the Ids parameter. The following Ids are not valid: 0..)

This prevented users from setting custom fields on work items, requiring manual work for work item management tasks.

Root Cause

In WorkItemPatchBuilderImpl.cs, when the Fields parameter was specified, the code attempted to get the work item type definition to properly parse custom fields. However, it was passing WorkItem = 0 as a parameter, which is an invalid work item ID:

var wit = Data.GetItem<WebApiWorkItemType>(new { Type = wi.Fields["System.WorkItemType"], WorkItem = 0, Project = projectName });

Solution

Changed the code to use the actual work item ID that is already available in the wi parameter:

var wit = Data.GetItem<WebApiWorkItemType>(new { Type = wi.Fields["System.WorkItemType"], WorkItem = wi.Id, Project = projectName });

Example Usage

This command will now work correctly:

Set-TfsWorkItem -WorkItem 32710953 -Fields @{"System.State" = "Active"}

The fix is minimal and surgical - it only changes the specific line causing the issue without affecting any other functionality.

Fixes #245.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

• http://168.63.129.16:80/machine/
  • Triggering command: /usr/bin/python3 -u bin/WALinuxAgent-2.13.1.1-py3.9.egg -collect-logs (http block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to my firewall allow list

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[github-actions]

Test Results

  2 files   80 suites   1m 58s ⏱️
139 tests 139 ✅ 0 💤 0 ❌
278 runs  278 ✅ 0 💤 0 ❌

Results for commit 7a3e333.

♻️ This comment has been updated with latest results.

[igoravl]

Fixes #245