Fix positioning for videos with non-zero offsetTop/offsetLeft

[russelldavis]

Fixes #786

[pepijnmm]

O I see you used a different approach then before the Hulu bug. On which sites have you tested does this work on YouTube as well as hulu? I will test it when home later.(but can't test Hulu I don't have a subscription)

[russelldavis]

Yep I've tested a bunch on Youtube. I don't have a Hulu subscription either, but I've tested on other sites that were affected by the same bug as Hulu (due to a transform on the video location), e.g. Reddit. I've also tested on other sites that were affected by #786, e.g. https://mlb.com/news.

Also tested on several other sites in general, e.g. Amazon Prime Video and Vimeo.

[pepijnmm]

works good for me too!
for hulu I tried https://www.hulu.com/movie/good-boy trailer (didn't want horror but could not find other trailers XD )

I will close #845

thanks! Hope they merge it soon.

[pepijnmm]

@igrigorik do you have time to check this one out to fix to position of the vsc?

[igrigorik]

Apologies for the delay on the review and thank you for the fix! 👍🏻

[paulirish]

@russelldavis thanks for fixing this. 🙏

back when i introduced the bug in #752 i said

getBoundingClientRect takes transforms into account, but otherwise I think it has consistent semantics with offsetLeft/offsetTop. …

well... really dumb of me not to remember or consider a positioned parent's effect.

Appreciate you cleaning up my mess. :)