Skip to content

Conversation

@dotproto
Copy link
Contributor

This PR updates the extension to use Manifest V3, the latest version fo the Chrome extension platform. This migration was very easy because the changes required were limited to updating names and structures in manifest.json.

"manifest_version": 2,
"version": "0.7.0",
"manifest_version": 3,
"minimum_chrome_version": "89",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question why do we want to put the minimum chrome version on 89?
Why not keep it so that chrome users from 2020 could even install it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chrome 89 is the first stable release to support Manifest V3.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A thanks could not find it anywhere.

Copy link
Owner

@igrigorik igrigorik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pulling this together! Overall, 👍🏻

Before we merge, are there any behavior/capability changes to watch out for or test, as a consequence of moving to v3?

@dotproto
Copy link
Contributor Author

dotproto commented Sep 15, 2021

I don't think there are any other changes that affect this extension. Generally speaking though, yes, there a few different changes that extension developers should be aware of with the introduction of the new platform. They're covered in more detail in the Manifest V3 Overview, but to borrow from the Feature Summary section of that page:

There are a number of new features and functional changes for extensions using MV3:

You may also want to consult the Migrating to Manifest V3 guide for a more directly actionable set of changes.

@igrigorik igrigorik merged commit 8957961 into igrigorik:master Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants