Conversation
khaeru
reviewed
Nov 13, 2025
| @@ -0,0 +1,299 @@ | |||
| # ============================== | |||
Member
There was a problem hiding this comment.
This entire file can be dropped by using existing code:
.util.pycountry- This project should extend the COUNTRY_NAME mapping in that module (instead of defining
manual_map, below), then call the functioniso_3166_alpha_3().
- This project should extend the COUNTRY_NAME mapping in that module (instead of defining
.model.structure.- This project can call
get_codelist("node/R12")and then derive the structural info necessary from the code list.
- This project can call
Please ask if there is any lack of clarity or examples in existing code, or if it's not evident how to make the substitution.
khaeru
reviewed
Nov 13, 2025
| @@ -0,0 +1 @@ | |||
| """Runs with cost of capital in MESSAGE.""" | |||
Member
There was a problem hiding this comment.
I feel the top-level module name message_ix_models.project.investment might lead to confusion in the future if there are multiple projects that deal with investment (seems likely). Some ways to disambiguate would be to add a two-digit year to the module name:
message_ix_models.project.coc_25message_ix_models.project.investment_25
The choice of a CLI entry point mix-models coc points to the former.
khaeru
reviewed
Nov 13, 2025
| "message_ix_models.project.edits.cli", | ||
| "message_ix_models.project.navigate.cli", | ||
| "message_ix_models.project.ssp.cli", | ||
| "message_ix_models.project.investment.cli", # cli run name by coc |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the CoC (Cost of Capital) feature for issue #428 .
TODO
(key functions there, scenario runs finished, slowly clearing up...)
How to review
mix-models coc run --from="base" "coc reported" --dry-runand check if the workflow successfully generated.PR checklist