-
Notifications
You must be signed in to change notification settings - Fork 165
Adjust for strict type hinting in ixmp #963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+217
−99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop message_ix.util.ixmp4.on_ixmp4backend().
- Adjust hints in .core and .models. - Ignore missing type hints for pooch. - Remove outdated ignores for jpype, memory_profiler.
ca66b56
to
143c0dc
Compare
4 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #963 +/- ##
=====================================
Coverage 96.0% 96.1%
=====================================
Files 53 53
Lines 5026 5030 +4
=====================================
+ Hits 4829 4834 +5
+ Misses 197 196 -1
|
Remove all uses of deprecated ixmp.TimeSeries._backend("method", ...) shorthand.
- mypy v1.14.1 → v0.17 - ruff v0.9.1 → v0.12.4 - Replace legacy "ruff" hook with "ruff-check".
Distinguish current expected contents for ixmp.IXMP4Backend vs. JDBCBackend.
Temporary addition between the merge of iiasa/ixmp#581 and the next release.
86297f9
to
d093709
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iiasa/ixmp#581 by @glatterf42 expanded type hints to the entire code base.
This PR makes adjusts
message_ix
to address mypy errors arising from those changes, and take advantages of typing-related utilities added.This PR does not apply the same mypy settings for
message_ix
as inixmp
; that may be done in a later PR.How to review
Note that the CI checks all pass.
PR checklist
Add, expand, or update documentation.N/A