Fixes and enhancements. [10] by ivan-nginx · Pull Request #1574 · iissnan/hexo-theme-next

ivan-nginx · 2017-04-07T11:15:53Z

PART 1. Some small fixes.

Files modified:

UPD: ru language. 2eee68f
FIX: scroll percent now count only content div. 4bd315d

What's this?

Update russian language for feat: add the configure for declare copyright on posts #1497.
Scroll percent count only post content (without comments iframe preloading, for ex.).

PART 2. Add `save_scroll` option.

Option for saving vertical scroll position on each post/page in cookies.

Files modified:

ADD: save_scroll option in config. 16f97aa
ADD: save_scroll option in layout. c858f8e
ADD: save_scroll option in third-party. [bridge] 29b94d3
ADD: save_scroll API script (js.cookie v2.1.4). 94287c5
FIX: save_scroll main script file. [4] 0070675

How to use?

In Next _config.yml:

# Automatically saving scroll position on each post/page in cookies.
save_scroll: true

Update from original.

houndci-bot · 2017-04-07T11:16:01Z

source/js/src/scroll-cookie.js

@@ -0,0 +1,25 @@
+/* global NexT: true */


'NexT' is defined but never used.

houndci-bot · 2017-04-07T11:16:01Z

source/js/src/scroll-cookie.js

+
+  // Read position from cookie
+  if (Cookies.get('scroll-cookie') !== undefined) {
+    var cvalues = Cookies.get('scroll-cookie').split('|');


Mixed double and single quotes.
'Cookies' is not defined.

houndci-bot · 2017-04-07T11:16:01Z

source/js/src/scroll-cookie.js

+  });
+
+  // Read position from cookie
+  if (Cookies.get('scroll-cookie') !== undefined) {


Mixed double and single quotes.
'Cookies' is not defined.

houndci-bot · 2017-04-07T11:16:01Z

source/js/src/scroll-cookie.js

+  $(window).on('scroll', function() {
+    clearTimeout(timeout);
+    timeout = setTimeout(function () {
+      Cookies.set('scroll-cookie', ($(window).scrollTop() + '|' + rpath), { path: '' });


Mixed double and single quotes.
'Cookies' is not defined.

houndci-bot · 2017-04-07T11:16:02Z

source/js/src/scroll-cookie.js

+
+  // Write position in cookie
+  var timeout;
+  $(window).on('scroll', function() {


Mixed double and single quotes.

houndci-bot · 2017-04-07T11:16:02Z

source/js/src/js.cookie.js

+
+				key = encodeURIComponent(String(key));
+				key = key.replace(/%(23|24|26|2B|5E|60|7C)/g, decodeURIComponent);
+				key = key.replace(/[\(\)]/g, escape);


'escape' is not defined.

houndci-bot · 2017-04-07T11:16:02Z

source/js/src/js.cookie.js

+		registeredInModuleLoader = true;
+	}
+	if (typeof exports === 'object') {
+		module.exports = factory();


'module' is not defined.

houndci-bot · 2017-04-07T11:16:02Z

source/js/src/js.cookie.js

+;(function (factory) {
+	var registeredInModuleLoader = false;
+	if (typeof define === 'function' && define.amd) {
+		define(factory);


'define' is not defined.

houndci-bot · 2017-04-07T11:16:02Z

source/js/src/js.cookie.js

+ */
+;(function (factory) {
+	var registeredInModuleLoader = false;
+	if (typeof define === 'function' && define.amd) {


'define' is not defined.

houndci-bot · 2017-04-07T11:16:02Z

source/js/src/js.cookie.js

+		var result = {};
+		for (; i < arguments.length; i++) {
+			var attributes = arguments[ i ];
+			for (var key in attributes) {


The body of a for in should be wrapped in an if statement to filter unwanted properties from the prototype.

houndci-bot · 2017-04-07T11:16:03Z

source/js/src/scroll-cookie.js

@@ -0,0 +1,25 @@
+/* global NexT: true */


'NexT' is defined but never used.

houndci-bot · 2017-04-07T11:16:03Z

source/js/src/scroll-cookie.js

+
+  // Read position from cookie
+  if (Cookies.get('scroll-cookie') !== undefined) {
+    var cvalues = Cookies.get('scroll-cookie').split('|');


Mixed double and single quotes.
'Cookies' is not defined.

houndci-bot · 2017-04-07T11:16:03Z

source/js/src/scroll-cookie.js

+  });
+
+  // Read position from cookie
+  if (Cookies.get('scroll-cookie') !== undefined) {


Mixed double and single quotes.
'Cookies' is not defined.

houndci-bot · 2017-04-07T11:16:03Z

source/js/src/scroll-cookie.js

+  $(window).on('scroll', function() {
+    clearTimeout(timeout);
+    timeout = setTimeout(function () {
+      Cookies.set('scroll-cookie', ($(window).scrollTop() + '|' + rpath), { path: '' });


Mixed double and single quotes.
'Cookies' is not defined.

houndci-bot · 2017-04-07T11:16:03Z

source/js/src/scroll-cookie.js

+
+  // Write position in cookie
+  var timeout;
+  $(window).on('scroll', function() {


Mixed double and single quotes.

houndci-bot · 2017-04-07T11:16:03Z

source/js/src/js.cookie.js

+
+				key = encodeURIComponent(String(key));
+				key = key.replace(/%(23|24|26|2B|5E|60|7C)/g, decodeURIComponent);
+				key = key.replace(/[\(\)]/g, escape);


'escape' is not defined.

houndci-bot · 2017-04-07T11:16:04Z

source/js/src/js.cookie.js

+		registeredInModuleLoader = true;
+	}
+	if (typeof exports === 'object') {
+		module.exports = factory();


'module' is not defined.

houndci-bot · 2017-04-07T11:16:04Z

source/js/src/js.cookie.js

+;(function (factory) {
+	var registeredInModuleLoader = false;
+	if (typeof define === 'function' && define.amd) {
+		define(factory);


'define' is not defined.

houndci-bot · 2017-04-07T11:16:04Z

source/js/src/js.cookie.js

+ */
+;(function (factory) {
+	var registeredInModuleLoader = false;
+	if (typeof define === 'function' && define.amd) {


'define' is not defined.

houndci-bot · 2017-04-07T11:16:04Z

source/js/src/js.cookie.js

+		var result = {};
+		for (; i < arguments.length; i++) {
+			var attributes = arguments[ i ];
+			for (var key in attributes) {


The body of a for in should be wrapped in an if statement to filter unwanted properties from the prototype.

houndci-bot · 2017-04-07T11:16:05Z

source/js/src/scroll-cookie.js

@@ -0,0 +1,25 @@
+/* global NexT: true */


'NexT' is defined but never used.

houndci-bot · 2017-04-07T11:16:05Z

source/js/src/scroll-cookie.js

+
+  // Read position from cookie
+  if (Cookies.get('scroll-cookie') !== undefined) {
+    var cvalues = Cookies.get('scroll-cookie').split('|');


Mixed double and single quotes.
'Cookies' is not defined.

houndci-bot · 2017-04-07T11:16:05Z

source/js/src/scroll-cookie.js

+  });
+
+  // Read position from cookie
+  if (Cookies.get('scroll-cookie') !== undefined) {


Mixed double and single quotes.
'Cookies' is not defined.

houndci-bot · 2017-04-07T11:16:05Z

source/js/src/scroll-cookie.js

+  $(window).on('scroll', function() {
+    clearTimeout(timeout);
+    timeout = setTimeout(function () {
+      Cookies.set('scroll-cookie', ($(window).scrollTop() + '|' + rpath), { path: '' });


Mixed double and single quotes.
'Cookies' is not defined.

houndci-bot · 2017-04-07T11:16:05Z

source/js/src/scroll-cookie.js

+
+  // Write position in cookie
+  var timeout;
+  $(window).on('scroll', function() {


Mixed double and single quotes.

houndci-bot · 2017-04-07T11:16:05Z

source/js/src/js.cookie.js

+
+				key = encodeURIComponent(String(key));
+				key = key.replace(/%(23|24|26|2B|5E|60|7C)/g, decodeURIComponent);
+				key = key.replace(/[\(\)]/g, escape);


'escape' is not defined.

houndci-bot · 2017-04-07T11:16:05Z

source/js/src/js.cookie.js

+		registeredInModuleLoader = true;
+	}
+	if (typeof exports === 'object') {
+		module.exports = factory();


'module' is not defined.

houndci-bot · 2017-04-07T11:16:06Z

source/js/src/js.cookie.js

+;(function (factory) {
+	var registeredInModuleLoader = false;
+	if (typeof define === 'function' && define.amd) {
+		define(factory);


'define' is not defined.

houndci-bot · 2017-04-07T11:16:06Z

source/js/src/js.cookie.js

+ */
+;(function (factory) {
+	var registeredInModuleLoader = false;
+	if (typeof define === 'function' && define.amd) {


'define' is not defined.

houndci-bot · 2017-04-07T11:16:06Z

source/js/src/js.cookie.js

+		var result = {};
+		for (; i < arguments.length; i++) {
+			var attributes = arguments[ i ];
+			for (var key in attributes) {


The body of a for in should be wrapped in an if statement to filter unwanted properties from the prototype.

houndci-bot · 2017-04-07T11:25:35Z

source/js/src/scroll-cookie.js

+  });
+
+  // Read position from cookie
+  if (Cookies.get("scroll-cookie") !== undefined) {


'Cookies' is not defined.

houndci-bot · 2017-04-07T11:25:35Z

source/js/src/scroll-cookie.js

+
+  // Read position from cookie
+  if (Cookies.get("scroll-cookie") !== undefined) {
+    var cvalues = Cookies.get('scroll-cookie').split('|');


Mixed double and single quotes.
'Cookies' is not defined.

houndci-bot · 2017-04-07T11:25:35Z

source/js/src/scroll-cookie.js

+  $(window).on("scroll", function() {
+    clearTimeout(timeout);
+    timeout = setTimeout(function () {
+      Cookies.set('scroll-cookie', ($(window).scrollTop() + '|' + rpath), { path: '' });


Mixed double and single quotes.
'Cookies' is not defined.

houndci-bot · 2017-04-07T11:25:35Z

source/js/src/scroll-cookie.js

@@ -0,0 +1,23 @@
+$(document).ready(function() {
+
+  // Set relative link path (without domain): https://stackoverflow.com/questions/3955959/whats-an-easy-way-to-get-the-url-in-the-current-window-minus-the-domain-name


Line is too long.

houndci-bot · 2017-04-07T11:30:47Z

source/js/src/scroll-cookie.js

+  $(window).on("scroll", function() {
+    clearTimeout(timeout);
+    timeout = setTimeout(function () {
+      Cookies.set("scroll-cookie", ($(window).scrollTop() + '|' + rpath), { path: '' });


Mixed double and single quotes.
'Cookies' is not defined.

houndci-bot · 2017-04-07T11:30:47Z

source/js/src/scroll-cookie.js

+  $(window).on("scroll", function() {
+    clearTimeout(timeout);
+    timeout = setTimeout(function () {
+      Cookies.set("scroll-cookie", ($(window).scrollTop() + '|' + rpath), { path: '' });


Mixed double and single quotes.
'Cookies' is not defined.

iissnan · 2017-04-09T06:39:39Z

Thanks. 👍

ivan-nginx added 8 commits April 7, 2017 13:00

Merge pull request #8 from iissnan/master

387bba4

Update from original.

UPD: ru language.

2eee68f

FIX: scroll percent now count only content div.

4bd315d

ADD: save_scroll option in config.

16f97aa

ADD: save_scroll option in layout.

c858f8e

ADD: save_scroll option in third-party. [bridge]

29b94d3

ADD: save_scroll API script (js.cookie v2.1.4).

94287c5

ADD: save_scroll main script file.

a18287d

houndci-bot reviewed Apr 7, 2017

View reviewed changes

FIX: save_scroll main script file.

73ca38e

houndci-bot reviewed Apr 7, 2017

View reviewed changes

FIX: save_scroll main script file. [2]

35b9648

houndci-bot reviewed Apr 7, 2017

View reviewed changes

ivan-nginx added 2 commits April 7, 2017 14:41

FIX: save_scroll main script file. [3]

579a788

FIX: save_scroll main script file. [4]

0070675

iissnan merged commit 9334f79 into iissnan:master Apr 9, 2017

ivan-nginx mentioned this pull request Apr 22, 2017

scrollpercent 进度显示有问题 #1615

Closed

ivan-nginx added 4 - Done Docs Enhancement labels Jul 24, 2017

ivan-nginx added this to the v.5.1.2 milestone Jul 24, 2017

ivan-nginx mentioned this pull request Dec 30, 2018

Fix #48 Footer position theme-next/hexo-theme-next#550

Merged

15 tasks

		@@ -0,0 +1,23 @@
		$(document).ready(function() {

		// Set relative link path (without domain): https://stackoverflow.com/questions/3955959/whats-an-easy-way-to-get-the-url-in-the-current-window-minus-the-domain-name

Conversation

ivan-nginx commented Apr 7, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PART 1. Some small fixes.

Files modified:

What's this?

PART 2. Add save_scroll option.

Files modified:

How to use?

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ivan-nginx commented Apr 7, 2017 •

edited

Loading

PART 2. Add `save_scroll` option.