Optimize Cohere2-MoE graph parallel#1948
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Cohere2 architecture is different from other architectures in that the input activations for a repeating layer are used as input to self-attention and also to the FFN portion of the network (while typically the self-attention output serves as the input to the FFN part). Because of this property one can save one
AllReduceoperation when using split modegraph. This is implemented for dense Cohere2 models, but not for the MoE variant just added in PR #1945. This PR adds the optimization of avoidingAllReduceon the result of self-attention also for Cohere2-MoE.Here is a
sweep=benchcomparison for North-Mini-Code-1.0 quantized withQ8_0on a 2x3090 system using split modegraphand-mugeMain branch
This PR