Conversation
added 10 commits
May 15, 2025 09:38
But is is not quite right, just like iq4_k, iq5_k, iq6_k, iq4_ks. All these need fixing on AVX2.
Contributor
|
Just did some testing of a mixed Thanks for adding, the quality looks really good for the size! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For motivation, see the CUDA performance graphs in #417 and #418.
Implementation for
AVX2, Zen4, ARM_NEON, CUDA, Metal.The
AVX2implementation suffers fromint16_toverflow, and so do theIQ4_K, IQ5_K, IQ6_KandIQ4_KS, so I will have to fix all of these in a follow up PR.I also want to add interleaved variant
IQ5_KS_R4before giving more performance and accuracy details.