Image reader #1014
Merged
Image reader #1014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fintelia
reviewed
Aug 21, 2019
Contributor
It seems easy enough to just dynamically create a |
fintelia
approved these changes
Aug 30, 2019
197g
commented
Sep 1, 2019
theotherphil
reviewed
Sep 1, 2019
197g
force-pushed
the
image-reader
branch
2 times, most recently
from
20d2d4a to
27f31bf
Compare
197g
commented
Sep 7, 2019
197g
commented
Sep 7, 2019
fintelia
approved these changes
Sep 25, 2019
Does not touch the public interface, only internal `_impl` variants which are simply referenced from their new location.
Firstly, simply renames load to decode. Also splits open into to operations: - open, which will inspect the file contents to guess the correct format *before* falling back to a path. - from_path, which imitates the old behaviour.
Don't deprecate them just yet, for now they are even the underlying primitives instead of being wrappers around the reader.
Fixes guess_format to only change the format on successful guesses.
Minimize the commitment of public interface for now. The builder style methods are likely the most immediately useful.
Member
Author
|
Got a weird failure, seems spurious and within the |
Member
Author
|
No, it's not spurious. But I'm not sure what to make of it: |
Member
Author
|
Going to ignore it: rust-lang/cargo#7429 |
Member
Author
|
I'm glad to finally have this landed. Thanks @fintelia for the review discussions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace free reader functions with
Readerstructure as sketched in this comment of #1007. This provides an api for reading image metadata and pixels without coupling to format guessing instead of adding all possible combinations of methods.Also makes the interface for directly turning an
ImageDecoderinto aDynamicImagepublic.Closes: #1007
Closes: #716
Closes: #577
Unresolved questions:
Should opening a file automatically try to guess the format from the first bytes? Or only from the path? From neither?Offer two methods.Offer a method and a builder style continuation.Should the path be contained in the data stored in theReader? This would allow other methods to emulate having opened a file, without going through the actualfsapi.ImageFormat::from_pathcan be used.Should there be a specialLater, if the need arises.loadfor formats which do not requireSeek?What about formats not requiringEasy to wrap inBufReadbut onlyRead?BufReader.