Add an AVIF decoder #1398
Merged
Add an AVIF decoder #1398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linkmauve
added a commit
to linkmauve/mp4parse-rust
that referenced
this pull request
Jan 14, 2021
The latter is required by image-rs/image#1398
197g
reviewed
Jan 16, 2021
There was a problem hiding this comment.
The amount of unsafe in decoder is not yet very reassuring, particularly without safety comments. If that combination, deriving a slice from the plane_data_ptr and plane_data_geometry, is always safe then I'm wondering why this is not an abstraction provided in the dav1d crate?
linkmauve
force-pushed
the
avif-decoder
branch
2 times, most recently
from
84c72fe to
4aa5e27
Compare
197g
reviewed
Jan 18, 2021
linkmauve
force-pushed
the
avif-decoder
branch
from
4aa5e27 to
f4451f6
Compare
linkmauve
force-pushed
the
avif-decoder
branch
from
f4451f6 to
0308008
Compare
|
There, both the mp4parse and dav1d crates got a release, I’ve updated this PR to use the non-git version. |
197g
approved these changes
Jan 27, 2021
197g
requested changes
Jan 27, 2021
linkmauve
force-pushed
the
avif-decoder
branch
from
0308008 to
d63ad64
Compare
197g
approved these changes
Jan 28, 2021
|
Thanks a lot. ETA: next weekend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This encoder so far only supports 8-bit data, and due to #1217 is much less efficient than it could be, as data is always converted to BGRA8888. I could also add support for I8 and IA88, but those formats are uncommon enough we can probably ignore the inefficiency for a first version.
This is 5am quality code, so no error handling but
.unwrap(), and there are someunsafeblocks which could possibly be avoided, I will get back to it after a first round of review.This also depends on mozilla/mp4parse-rust#266 to build.
Fixes #1152.