fix: link render hook produces dangling links when base URL has additional segments #660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for hugo-hextra ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Closed
Owner
|
@oosquare thank you for the fix
I agree that respecting the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the website is configured with
baseURL = "https://example.com/sub-website/", the current link render hook will turn[](/some/link)to<a href="https://example.com/some/link"></a>rather than<a href="https://example.com/sub-website/some/link"></a>. A real-world example is the theme's documentation website, where a link with a title ofOrganize Filewill be redirected to the 404 page. This PR fixes this problem. Note that merging this will introduce a breaking change, but I personally think that this makes sense, in that the Hextra theme haven't published a major release ever since.By the way, in my last PR #657, I mistakenly used
?for URL fragments. The fix is rather apparent, which is only a one-character substitution, so I put it along with this PR for convenience and simplicity. Apology for my carelessness.