You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have made corresponding changes to the documentation if applicable
I have no unrelated changes in the PR.
I have confirmed that any new dependencies are strictly necessary.
I have written tests for new code (if applicable)
I have followed naming conventions/patterns in the surrounding code
All code in src/services/ uses repositories implementations for database calls, filesystem operations, etc.
All code in src/repositories/ is pretty basic/simple and does not have any immich specific logic (that belongs in src/services/)
Please describe to which degree, if any, an LLM was used in creating this pull request.
...
In future entire scrub thing needs to be refactored allowing the users to decide when do they want to call onscrub after releasing button or while dragging, for performance purposes. For now we should just fix this one to begin with.
What i've been working with locally + deleted off screenshot changes related to detecting single clicks because they're also recognized as dragging...
What exactly are you trying to "fix" here? The original issue you linked has long been resolved, and I also don't see how your comments on that issue (they shouldn't be on that issue in the first place but oh well) relate to this PR either.
Can you like very explicitly provide reproduction steps and elaborate on what you'd expect to happen and what actually happens (and why that's an issue)?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4180
How Has This Been Tested?
Screenshots (if appropriate)
Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)Please describe to which degree, if any, an LLM was used in creating this pull request.
...
In future entire scrub thing needs to be refactored allowing the users to decide when do they want to call onscrub after releasing button or while dragging, for performance purposes. For now we should just fix this one to begin with.
What i've been working with locally + deleted off screenshot changes related to detecting single clicks because they're also recognized as dragging...
