Skip to content

fix(web): double callback on initial click and drag#26878

Closed
ghost wants to merge 4 commits intomainfrom
unknown repository
Closed

fix(web): double callback on initial click and drag#26878
ghost wants to merge 4 commits intomainfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Mar 12, 2026

Description

Fixes #4180

How Has This Been Tested?

  • Test A
  • Test B

Screenshots (if appropriate)

Checklist:

  • I have carefully read CONTRIBUTING.md
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if applicable
  • I have no unrelated changes in the PR.
  • I have confirmed that any new dependencies are strictly necessary.
  • I have written tests for new code (if applicable)
  • I have followed naming conventions/patterns in the surrounding code
  • All code in src/services/ uses repositories implementations for database calls, filesystem operations, etc.
  • All code in src/repositories/ is pretty basic/simple and does not have any immich specific logic (that belongs in src/services/)

Please describe to which degree, if any, an LLM was used in creating this pull request.

...

In future entire scrub thing needs to be refactored allowing the users to decide when do they want to call onscrub after releasing button or while dragging, for performance purposes. For now we should just fix this one to begin with.

What i've been working with locally + deleted off screenshot changes related to detecting single clicks because they're also recognized as dragging...
image

@ghost ghost requested a review from danieldietzler as a code owner March 12, 2026 14:27
@ghost ghost changed the title Fix double callback on initial click and drag fix: Fix double callback on initial click and drag Mar 12, 2026
@alextran1502
Copy link
Member

Maybe the fix is to prevent double callbacks in the first place rather than introducing a local variable?

@ghost
Copy link
Author

ghost commented Mar 12, 2026

Maybe the fix is to prevent double callbacks in the first place rather than introducing a local variable?

i am not sure who wrote the code, that's the thing...

the issue is, we can obviously put a return there, but its all up to you, if you want i can, not sure what the coding style those guys were following

@ghost ghost changed the title fix: Fix double callback on initial click and drag fix(web): Fix double callback on initial click and drag Mar 12, 2026
@bwees bwees changed the title fix(web): Fix double callback on initial click and drag fix(web): double callback on initial click and drag Mar 12, 2026
@danieldietzler danieldietzler requested a review from midzelis March 12, 2026 18:28
@danieldietzler
Copy link
Member

danieldietzler commented Mar 16, 2026

What exactly are you trying to "fix" here? The original issue you linked has long been resolved, and I also don't see how your comments on that issue (they shouldn't be on that issue in the first place but oh well) relate to this PR either.
Can you like very explicitly provide reproduction steps and elaborate on what you'd expect to happen and what actually happens (and why that's an issue)?

@ghost
Copy link
Author

ghost commented Mar 16, 2026

cant be bothered bro

@ghost ghost closed this Mar 16, 2026
@immich-app immich-app deleted a comment Mar 17, 2026
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Web client has major performance issues with large image library

3 participants