fix: utils requires for resolver-node to be dependent #828#1492
Closed
anion155 wants to merge 1 commit into
Closed
fix: utils requires for resolver-node to be dependent #828#1492anion155 wants to merge 1 commit into
anion155 wants to merge 1 commit into
Conversation
anion155
changed the title
anion155
changed the title
6 similar comments
ljharb
reviewed
Oct 1, 2019
ljharb
left a comment
ljharb
left a comment
Member
There was a problem hiding this comment.
See #828 (comment) for the proper solution to #828.
| "pkg-dir": "^2.0.0" | ||
| }, | ||
| "peerDependencies": { | ||
| "eslint-import-resolver-node": "^0.3.2" |
Member
There was a problem hiding this comment.
this definitely isn't the right solution; eslint-module-utils does not require the node resolver.
Author
|
@ljharb Sorry for long reaction. So then, add |
Member
|
I'm still not sure what the underlying issue is; but anything that works with #828 (comment) is the expected solution here. Want to update the PR to do only that? |
Member
|
This seems to have been fixed by #1591. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #828.
Tested with pnpm by linking resolver-node to module-utils's node_modules folder as if it was declared in peerDependencies, it worked. So I'm assuming just putting it in peerDependencies would work too.