Skip to content

Use createRequire instead of createRequireFromPath if available #1602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 11, 2020
Merged

Use createRequire instead of createRequireFromPath if available #1602

merged 1 commit into from
Jan 11, 2020

Conversation

iamnapo
Copy link
Contributor

@iamnapo iamnapo commented Jan 11, 2020 •
edited
Loading

In order to avoid: DeprecationWarning: Module.createRequireFromPath() is deprecated. Use Module.createRequire() instead. when using Node >= v12.2.0.

@coveralls
Copy link

coveralls commented Jan 11, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 97.874% when pulling bcd9fe8 on iamnapo:module-deprecation-warning into d8c6795 on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.874% when pulling d16dc0b on iamnapo:module-deprecation-warning into d8c6795 on benmosher:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.874% when pulling d16dc0b on iamnapo:module-deprecation-warning into d8c6795 on benmosher:master.

@ljharb ljharb added the package: utils eslint-module-utils package label Jan 11, 2020
ljharb
ljharb approved these changes Jan 11, 2020
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks great!

@ljharb
Copy link
Member

ljharb commented Jan 11, 2020

cc @arcanis as a heads up

@ljharb ljharb merged commit bcd9fe8 into import-js:master Jan 11, 2020
@iamnapo iamnapo deleted the module-deprecation-warning branch January 12, 2020 08:40
@haoqunjiang haoqunjiang mentioned this pull request Jan 19, 2020
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
package: utils eslint-module-utils package
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iamnapo @coveralls @ljharb