Skip to content

Use createRequire instead of createRequireFromPath if available#1602

Merged
ljharb merged 1 commit into
import-js:masterfrom
iamnapo:module-deprecation-warning
Jan 11, 2020
Merged

Use createRequire instead of createRequireFromPath if available#1602
ljharb merged 1 commit into
import-js:masterfrom
iamnapo:module-deprecation-warning

Conversation

@iamnapo

@iamnapo iamnapo commented Jan 11, 2020

Copy link
Copy Markdown
Contributor

In order to avoid: DeprecationWarning: Module.createRequireFromPath() is deprecated. Use Module.createRequire() instead. when using Node >= v12.2.0.

@coveralls

coveralls commented Jan 11, 2020

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 97.874% when pulling bcd9fe8 on iamnapo:module-deprecation-warning into d8c6795 on benmosher:master.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 97.874% when pulling d16dc0b on iamnapo:module-deprecation-warning into d8c6795 on benmosher:master.

1 similar comment
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 97.874% when pulling d16dc0b on iamnapo:module-deprecation-warning into d8c6795 on benmosher:master.

@ljharb ljharb added the package: utils eslint-module-utils package label Jan 11, 2020

@ljharb ljharb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks great!

@ljharb

ljharb commented Jan 11, 2020

Copy link
Copy Markdown
Member

cc @arcanis as a heads up

@ljharb ljharb merged commit bcd9fe8 into import-js:master Jan 11, 2020
@iamnapo iamnapo deleted the module-deprecation-warning branch January 12, 2020 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: utils eslint-module-utils package

Development

Successfully merging this pull request may close these issues.

3 participants