[Docs] order: update the description of the pathGroupsExcludedImportTypes option#2239
Closed
liby wants to merge 1 commit intoimport-js:mainfrom
liby:master
Closed
[Docs] order: update the description of the pathGroupsExcludedImportTypes option#2239liby wants to merge 1 commit intoimport-js:mainfrom liby:master
pathGroupsExcludedImportTypes option#2239liby wants to merge 1 commit intoimport-js:mainfrom
liby:master
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2239 +/- ##
==========================================
- Coverage 95.23% 94.63% -0.60%
==========================================
Files 65 65
Lines 2686 2686
Branches 888 888
==========================================
- Hits 2558 2542 -16
- Misses 128 144 +16 ☔ View full report in Codecov by Sentry. |
Contributor
|
Sorry, I missed this PR when it was opened, but yes the changes are correct and the current documentation is wrong. Using patterns as excluded types works accidentally because the default types are removed. |
Member
|
it's very unfortunate that the fork was deleted, making this PR unrecoverable, so now we need #3036 as a duplicate :-/ please never delete a fork that has open PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation: #2156
@Mairu @Akiq2016 @yola-0316 PTAL.