Skip to content

Conversation

@philipp-spiess
Copy link

@philipp-spiess philipp-spiess commented Dec 18, 2025

For your pull request to not get closed without review, please confirm that:

  • An issue exists where the maintainers agreed that this should be implemented.
    If such issue did not exist before, I opened one.
  • I tested that my contribution works locally, and does not break anything,
    otherwise I have marked my PR as draft.
  • If my contribution is non-trivial, I did not use AI to write most of it.
  • I understand that I will be permanently banned from interacting with this
    organization if I lied by checking any of these checkboxes.

Tested on (check one or more):

  • Windows
  • macOS
  • Linux

This PR changes the minimum window width such that the browser can size beyond 500px to make it easier to test responsive viewports without being forced to open devtools et al.

All of the research of this and the code was written by Codex but it seems trivial enough. I've been testing it on macOS.

To give some added context, the BrowserViewLayout::GetMinimumSize method is responsible for computing the minimum viewport and it does that by taking multiple minimums into accounts. In addition to changing two hardcoded minimum widths, the toolbar was constrained by the omnibox minimum characters.

However, reducing the omnibox min chars clashes with this change in the experimental one-line toolbar. To resolve this I'm proposing we hide the back, forward, and refresh buttons in these ultra-small viewports (<500px) and keep the min chars as-is.

Before

CleanShot 2025-12-18 at 23 35 05@2x

After

CleanShot.2025-12-21.at.23.05.24.mp4

@philipp-spiess philipp-spiess force-pushed the smaller-minimum-width branch 2 times, most recently from ad635e5 to a898361 Compare December 19, 2025 12:55
@philipp-spiess philipp-spiess marked this pull request as draft December 19, 2025 12:56
@philipp-spiess
Copy link
Author

Just noticed that this clashes with this change here: e9de843#diff-2826944ab8480d94ea497b4162f31b7ef9781cdfc282596674f87906931560c1R244-R245

One thing we could do to preserve some space in this view is to hide the back/forward/refresh buttons in small viewports? I had this working initially but decided to remove the code to keep the diff leaner.

@philipp-spiess philipp-spiess marked this pull request as ready for review December 20, 2025 23:14
@philipp-spiess philipp-spiess marked this pull request as draft December 20, 2025 23:24
@philipp-spiess
Copy link
Author

Alright opening this up for review again. This PR now hides the back/forward/refresh buttons as suggested. PR description is updated and I made sure the code change is minimal. Attached is also a video of the new behavior in both modes. Would love some input at that point if know if you think this idea is worth exploring more :)

@philipp-spiess philipp-spiess marked this pull request as ready for review December 21, 2025 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant