[HTP-117] GumGum - updates bidUnitInCents #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Pls update changes.md and add updated version number. |
Contributor
Author
|
@ix-certification updated! please let me know if there's anything else I need to update |
susyt
changed the title
Contributor
Author
|
hi @ix-certification |
Contributor
|
Hello, checking in on this pull request. Can you confirm this is still a pending request for IX? |
Contributor
Author
|
hi @ix-certification - yes, please review! |
Contributor
Author
|
hi @ix-certification , is there anything needed for this PR to get reviewed? |
Contributor
Author
|
hi @ix-certification, I added another small change into this PR since I'm unable to access jira.indexexchange.com to create another request -> please let me know if there's anything else needed. thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description of Change
Adds bF parameter and changes bidUnitInCents instead of multiplying bidprice by 100