Skip to content

Use ReactNode type for children props #2385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pascalbaljet merged 1 commit into from
Jul 31, 2025
Merged

Use ReactNode type for children props #2385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/react/src/Deferred.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { ReactElement, useEffect, useMemo, useState } from 'react'
import { ReactNode, useEffect, useMemo, useState } from 'react'
import { router } from '.'
import usePage from './usePage'

Expand All @@ -14,8 +14,8 @@ const isSameUrlWithoutHash = (url1: URL | Location, url2: URL | Location): boole
}

interface DeferredProps {
children: ReactElement | number | string
fallback: ReactElement | number | string
children: ReactNode
fallback: ReactNode
data: string | string[]
}

Expand Down
6 changes: 3 additions & 3 deletions packages/react/src/WhenVisible.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import { ReloadOptions, router } from '@inertiajs/core'
import { createElement, ReactElement, useCallback, useEffect, useRef, useState } from 'react'
import { createElement, ReactNode, useCallback, useEffect, useRef, useState } from 'react'

interface WhenVisibleProps {
children: ReactElement | number | string
fallback: ReactElement | number | string
children: ReactNode
fallback: ReactNode
data?: string | string[]
params?: ReloadOptions
buffer?: number
Expand Down