-
Notifications
You must be signed in to change notification settings - Fork 29
Revamp plugin logic RE #26 #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
It's been a minute since I drafted this and now some packages have major bumps which change Node support. I will leave them as they are so this upgrade supports anyone who hasn't bumped to higher ESLint versions yet |
Hey! What's the status of this PR? I realize it's a huge revamp, but it does seem necessary. Is the original project here still maintained or would it make sense to fork and finish/release this PR as a separate package? |
Firstly, thanks for taking the time to look at this. Apologies the PR is so large. When I realized my attempt at patching the swap behavior for #26 wasn't going to work, this seemed like the next best approach, but I felt it had to come with proper testing given the breadth of work required. I tried to reuse as much as I could, but the amount of edge cases required adding/replacing a lot of logic. Definitely open to feedback on this approach if anything is simpler/more sound, even if its nontrivial.
Changes included
stylistic
instead ofwarn
string-enum
(Consider sorting other types of enums? #72)Package maintenance
fewer
strategyMisc changes
Known caveats & work left
I think this update should be released first as
4.0.0-alpha.1
in case anything goes terribly wrong.