Skip to content

fix(entrypoint): Preserve $ in passwords during template expansion#12509

Merged
KevinHuSh merged 1 commit intoinfiniflow:mainfrom
zagnaan:bugfix/preserve-dollar-sign
Jan 15, 2026
Merged

fix(entrypoint): Preserve $ in passwords during template expansion#12509
KevinHuSh merged 1 commit intoinfiniflow:mainfrom
zagnaan:bugfix/preserve-dollar-sign

Conversation

@zagnaan
Copy link
Contributor

@zagnaan zagnaan commented Jan 8, 2026

What problem does this PR solve?

Fix shell variable expansion to preserve $ in password defaults when
env vars are unset. Fixes Azure RDS auto-rotated passwords (that contain $) being
truncated during template processing.

Type of change

  • Bug Fix (non-breaking change which fixes an issue)

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jan 8, 2026
@KevinHuSh
Copy link
Collaborator

Appreciations!
By our evalutions, this feature is not going to be merged into main branch.

@KevinHuSh KevinHuSh closed this Jan 13, 2026
@gileslloyd
Copy link
Contributor

@KevinHuSh I'm having a fatal error with ragflow due to the bug this PR attempts to resolve. Is there a fix incoming for this or an alternative you'd recommend? There's no explanation as to why this PR was rejected

@KevinHuSh KevinHuSh reopened this Jan 15, 2026
@KevinHuSh KevinHuSh added the ci Continue Integration label Jan 15, 2026
@KevinHuSh KevinHuSh marked this pull request as draft January 15, 2026 06:53
@KevinHuSh KevinHuSh marked this pull request as ready for review January 15, 2026 06:53
@KevinHuSh KevinHuSh merged commit 59f4c51 into infiniflow:main Jan 15, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continue Integration size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants