Skip to content

Enterprise multi-node recommendations and Python libraries update #6107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Jun 9, 2025

Conversation

MeelahMe
Copy link
Contributor

…ly deployments

Closes #6053

@MeelahMe MeelahMe requested review from Copilot, peterbarnett03 and jstirnaman and removed request for peterbarnett03 May 29, 2025 17:36
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refines documentation for plugin development and deployment and updates the JS config for module resolution.

  • Overhauls Python dependency installation instructions with embedded environment guidance and CLI/Docker examples.
  • Introduces distributed cluster considerations, mapping plugin triggers to node roles and routing client traffic.
  • Simplifies jsconfig.json by removing node_modules from the paths mapping.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
content/shared/v3-core-plugins/_index.md Expanded and clarified docs for Python package installation and multi-node deployment
assets/jsconfig.json Removed ../node_modules/* from paths to streamline module resolution
Comments suppressed due to low confidence (2)

content/shared/v3-core-plugins/_index.md:564

  • This description refers to creating a Python virtual environment, but the embedded environment is managed by the Processing Engine. Update this line to clarify that influxdb3 install package places dependencies into the engine’s embedded environment.
This creates a Python virtual environment in your plugins directory with the specified packages installed.

assets/jsconfig.json:6

  • Removing "../node_modules/*" from the paths may prevent the IDE or build from resolving modules in node_modules. Verify this change doesn’t break local development or consider documenting the new resolution behavior.
*

| HTTP request | `path:` | Nodes that serve API traffic|

For example:
- Run write-ahead log (WAL) plugins on ingester nodes.
Copy link
Preview

Copilot AI May 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The example mentions WAL plugins but the trigger types table lists only data write, scheduled, and HTTP request triggers. Consider aligning the example with the table or explaining how WAL plugins map to the data write category.

Copilot uses AI. Check for mistakes.

@MeelahMe MeelahMe marked this pull request as ready for review May 29, 2025 17:37
@MeelahMe MeelahMe requested a review from jstirnaman June 9, 2025 19:13
Copy link
Contributor

@jstirnaman jstirnaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 nit. Looks great!

Comment on lines +526 to +527
Use the `influxdb3 install package` command to add third-party libraries (like `pandas`, `requests`, or `influxdb3-python`) to your plugin environment.
This installs packages into the Processing Engine’s embedded Python environment to ensure compatibility with your InfluxDB instance.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@MeelahMe MeelahMe merged commit 3b0f77c into master Jun 9, 2025
1 check passed
@MeelahMe MeelahMe deleted the docs/generalize-grafana-multinode branch June 9, 2025 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add recommendation to Enterprise multi-node recommendations
2 participants