Skip to content

There is a thread safety issue with InfluxDBResultMapper #683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mayuefeng777 opened this issue Jun 15, 2020 · 1 comment · Fixed by #685
Closed

There is a thread safety issue with InfluxDBResultMapper #683

mayuefeng777 opened this issue Jun 15, 2020 · 1 comment · Fixed by #685
Labels
kind/bug

Comments

@mayuefeng777
Copy link
Contributor

When I run the toPOJO method from the InfluxDBResultMapper in a multithreaded environment, some fields of the objects returned are null in some special cases.

Then I debugged and figured out that there is some problem in the cacheMeasurementClass method. When the first thread puts the measurement class into the cache map CLASS_FIELD_CACHE and before it finish putting all the field of the measurement class into cache, other threads would get an incomplete cache object.

I think it‘s better to make it synchronized or move the step of putting the measurement class into the cache map to the end, at least after all the field of the measurement class cached.
@russorat
Copy link

@mayuefeng777 thanks for the report. Are you interested in opening a PR?

mayuefeng777 pushed a commit to mayuefeng777/influxdb-java that referenced this issue Jun 28, 2020
fix issue: There is a thread safety issue with InfluxDBResultMapper i…
8b373a3 
…nfluxdata#683
@mayuefeng777 mayuefeng777 mentioned this issue Jun 28, 2020
Merged
majst01 pushed a commit that referenced this issue Jul 20, 2020
@mayuefeng777
fix issue: There is a thread safety issue with InfluxDBResultMapper #683
93c0093 
 (#685)

Co-authored-by: mayuefeng <[email protected]>
@bennycwlau bennycwlau mentioned this issue Mar 30, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix issue: There is a thread safety issue with InfluxDBResultMapper #683 mayuefeng777/influxdb-java
2 participants
@russorat @mayuefeng777