PR template clippy surf OR reqwest

[ctrlaltf24]

Description

PR Template check of cargo clippy --all-targets --all-features -- -D warnings errors due to --all-features importing both surf and reqwest. Split into two separate checks.

Checklist

• Formatted code using cargo fmt --all
• Linted code using clippy cargo clippy --all-targets --all-features -- -D warnings
• Updated README.md using cargo readme -r influxdb -t ../README.tpl > README.md
• Reviewed the diff. Did you leave any print statements or unnecessary comments?
  • The last line change is adding a newline at the end of the file.
• Any unfinished work that warrants a separate issue captured in an issue with a TODO code comment

[msrd0]

Thanks for catching this, we definitely need to change that. However, while surf and reqwest might be ok with enabling several features, I don't think it adds any value to have all surf-based or all reqwest-based features enabled (and let surf/reqwest decide which client / tls library will be used).

Wouldn't it be sufficient to use those commands we also use for the CI? (otherwise we should maybe change the CI commands)

[ctrlaltf24]

I don't think it adds any value to have all surf-based or all reqwest-based features enabled

If the features aren't enabled, clippy won't detect errors that are masked by #cfg . While such an issue rarely happens, would still be nice if it was caught before users that specify that feature have issues with a released version.

Feel free to hijack this PR and make any commits you want (I gave you permission to push on the fork) to get the documentation where it should be. Just something I noticed that I wanted to bring to your attention.

[msrd0]

If the features aren't enabled, clippy won't detect errors that are masked by #cfg . While such an issue rarely happens, would still be nice if it was caught before users that specify that feature have issues with a released version.

Yes, absolutely. But we run cfg against surf and reqwest, but iirc not against any of the specific features (like reqwest-client-rustls). That's what I meant, sorry if I didn't express that clearly.