Skip to content

Lowercase Timestamps variants #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 27, 2019
Merged

Lowercase Timestamps variants #40

merged 2 commits into from
Oct 27, 2019

Conversation

ilse-macias
Copy link

@ilse-macias ilse-macias commented Oct 26, 2019 •
edited
Loading

Description

I changed timestamp variants form UPPERCASE to TitleCase. Fixes #39

Checklist

  • Formatted code using cargo fmt --all
  • Linted code using clippy cargo clippy --all-targets --all-features -- -D warnings
  • Updated README.md using cargo readme > README.md
  • Reviewed the diff. Did you leave any print statements or unnecessary comments?
  • Any unfinished work that warrants a separate issue captured in an issue with a TODO code comment

Lowercase Timestamps variants
759598c 
I changed timestamp variants form UPPERCASE to TitleCase.
@Empty2k12
Copy link
Collaborator

Thanks for this PR! 🎉

The CI is failing due to code style. Please run cargo fmt --all and commit, so we can merge this!

Empty2k12
Empty2k12 approved these changes Oct 26, 2019
View reviewed changes
Copy link
Collaborator

@Empty2k12 Empty2k12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will merge when CI passes. Thanks you very much for this contribution. Happy end of Hacktoberfest!

@Empty2k12 Empty2k12 added Status: Merge when CI passes This PR has been reviewed and accepted for merge and removed Status: Pending Updates labels Oct 26, 2019
@msrd0 msrd0 merged commit 1c809d3 into influxdb-rs:master Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Empty2k12 Empty2k12 Empty2k12 approved these changes

Assignees
No one assigned
Labels
Hacktoberfest Status: Merge when CI passes This PR has been reviewed and accepted for merge Type: Enhancement Type of Change: Minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lowercase Timestamp variants
3 participants
@ilse-macias @Empty2k12 @msrd0