Skip to content

Remove Code Coverage #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2019
Merged

Remove Code Coverage #44

merged 1 commit into from
Oct 30, 2019

Conversation

Empty2k12
Copy link
Collaborator

Description

Code Coverage is broken in Rust. Wrong lines are covered and features are incorrectly detected. This PR removes it and adds #43 as a tracking issue to add it back once working solutions are built and useable in this project.

Checklist

  • Formatted code using cargo fmt --all
  • Linted code using clippy cargo clippy --all-targets --all-features -- -D warnings
  • Updated README.md using cargo readme > README.md
  • Reviewed the diff. Did you leave any print statements or unnecessary comments?
  • Any unfinished work that warrants a separate issue captured in an issue with a TODO code comment

@Empty2k12 Empty2k12 requested a review from msrd0 October 30, 2019 12:44
@msrd0 msrd0 merged commit 208e81f into master Oct 30, 2019
@msrd0 msrd0 deleted the remove/code-coverage branch October 30, 2019 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msrd0 msrd0 msrd0 approved these changes

Assignees
No one assigned
Labels
Type: Chore Type of Change: Minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Empty2k12 @msrd0