Skip to content

Adding clone and debug to WriteQuery and ReadQuery. #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 21, 2020

Conversation

jaredwolff
Copy link
Contributor

Description

Making ReadQuery and WriteQuery Debug and Clone so they can be passed through channels.

Checklist

  • Formatted code using cargo fmt --all
  • Linted code using clippy cargo clippy --all-targets --all-features -- -D warnings

Note: it appears that there were some errors before my commit:

error: this import is redundant
--> influxdb/src/error.rs:2:1
|
2 | use reqwest;
| ^^^^^^^^^^^^ help: remove it entirely
|
= note: -D clippy::single-component-path-imports implied by -D warnings
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports

error: this import is redundant
--> influxdb/src/integrations/serde_integration.rs:52:1
|
52 | use serde_json;
| ^^^^^^^^^^^^^^^ help: remove it entirely
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports

error: this import is redundant
--> influxdb/src/error.rs:2:1
|
2 | use reqwest;
| ^^^^^^^^^^^^ help: remove it entirely
|
= note: -D clippy::single-component-path-imports implied by -D warnings
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports

error: this import is redundant
--> influxdb/src/integrations/serde_integration.rs:52:1
|
52 | use serde_json;
| ^^^^^^^^^^^^^^^ help: remove it entirely
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports

error: aborting due to 2 previous errors

error: could not compile influxdb.

  • Updated README.md using cargo readme > README.md
  • Reviewed the diff. Did you leave any print statements or unnecessary comments?
  • Any unfinished work that warrants a separate issue captured in an issue with a TODO code comment

@jaredwolff jaredwolff changed the title Implemeting clone and debug for WriteQuery an ReadQuery. Adding clone and debug to WriteQuery and ReadQuery. Aug 10, 2020
@Empty2k12 Empty2k12 self-assigned this Aug 12, 2020
@Empty2k12 Empty2k12 merged commit 0566811 into influxdb-rs:master Aug 21, 2020
@Empty2k12
Copy link
Collaborator

Thanks for this pull request! 👍🚀

Please excuse my slow response time, I am quite busy with university exams right now. Your patch will be released amongst the other pull requests when they are merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants