Skip to content

fix many types misuses #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 17, 2024
Merged

fix many types misuses #241

merged 3 commits into from
Jun 17, 2024

Conversation

drewwells
Copy link
Contributor

@drewwells drewwells commented Jun 14, 2024

    it appears constants were leveraged to avoid type checks in Go.
    This resulted in the wrong types on several key API objects which
    will be hard to fix now.

    Address some bad uses of types where possible. int was used in place
    of time.Duration() * time.Minute, causing confusing code.

@drewwells drewwells force-pushed the fixTypes branch 3 times, most recently from 090cb88 to defff73 Compare June 17, 2024 17:44
Drew Wells added 3 commits June 17, 2024 14:00
    it appears constants were leveraged to avoid type checks in Go.
    This resulted in the wrong types on several key API objects which
    will be hard to fix now.

    Address some bad uses of types where possible. int was used in place
    of time.Duration() * time.Minute, causing confusing code.
@drewwells drewwells marked this pull request as ready for review June 17, 2024 19:01
@drewwells drewwells merged commit 125b047 into main Jun 17, 2024
3 checks passed
@drewwells drewwells deleted the fixTypes branch June 17, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants