start recreation of project on kubebuilder v4 #244
Conversation
drewwells
force-pushed
the
kubebuilderv4
branch
15 times, most recently
from
61a21d0 to
f385aaa
Compare
|
|
||
| .PHONY: deploy | ||
| deploy-kustomize: manifests kustomize ## Deploy controller to the K8s cluster specified in ~/.kube/config. | ||
| cd config/manager && $(KUSTOMIZE) edit set image controller=${IMG_PATH}:${TAG} | ||
| $(KUSTOMIZE) build config/default | kubectl apply --namespace `cat .id` -f - |
There was a problem hiding this comment.
how do you specify the namespace to deploy this now that "--namespace was removed"?
We need it so more than 1 person can run integration tests in parallel
There was a problem hiding this comment.
dbc_end2end_test.go (line 58) relies on this namespace
|
|
||
| .PHONY: undeploy | ||
| undeploy-kustomize: ## Undeploy controller from the K8s cluster specified in ~/.kube/config. Call with ignore-not-found=true to ignore resource not found errors during deletion. | ||
| $(KUSTOMIZE) build config/default | kubectl delete --namespace `cat .id` --ignore-not-found=$(ignore-not-found) -f - |
There was a problem hiding this comment.
same here with namespace
There was a problem hiding this comment.
kubebuilder v3 vs v4 code. It didn't do the right thing before and won't work after either. We just have it b/c kubebuilder template creates it
|
|
||
| .PHONY: integration-test |
There was a problem hiding this comment.
how do we run integration tests in the new code?
There was a problem hiding this comment.
they don't run right now. I need to make a helm install process to setup the chart prior to running the existing tests
| LeaderElection: enableLeaderElection, | ||
| LeaderElectionID: "32151587.atlas.infoblox.com", |
There was a problem hiding this comment.
Is it ok to change the electionid? what processes creates the leaders in k8s?
There was a problem hiding this comment.
didn't notice that. Probably fine to change it, but reverting this back
https://book.kubebuilder.io/migration/migration_guide_gov3_to_gov4