PTEUDO-1096 perform reconcile tests on PR builds #251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewwells
force-pushed
the
enableDBControllerTests
branch
from
04c053f to
0ced28c
Compare
drewwells
changed the title
drewwells
force-pushed
the
enableDBControllerTests
branch
3 times, most recently
from
313f025 to
80ef190
Compare
Stand up a local postgres for testing
Fix many issues within the initial test suite that caused reconcile to fail
drewwells
force-pushed
the
enableDBControllerTests
branch
from
80ef190 to
d775a36
Compare
| cmd := exec.Command("make", "undeploy") | ||
| _, err := utils.Run(cmd) | ||
| Expect(err).NotTo(HaveOccurred()) | ||
| // By("Helm upgrading the manager") |
There was a problem hiding this comment.
Should we keep it or remove?
EvertonCalgarotto
approved these changes
Jul 9, 2024
| @@ -70,7 +70,7 @@ test: manifests generate fmt vet envtest ## Run tests. | |||
| .PHONY: test-e2e # Run the e2e tests against a Kind k8s instance that is spun up. | |||
| test-e2e: NS?=$(shell cat .id) | |||
| test-e2e: | |||
| NAMESPACE=$(NS) go test ./test/e2e/ -v -ginkgo.v | |||
| NAMESPACE=$(NS) ENV=box-3 go test ./test/e2e/ -v -ginkgo.v | |||
There was a problem hiding this comment.
What do you think of creating a file like the ".id" one to put the server instead of hardcoding it here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PTEUDO-1096 perform reconcile tests on PR builds