PTEUDO-1096 support crossplane CR tests in controller #259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
drewwells
commented
Jul 15, 2024
drewwells
commented
installs the crossplane CRs db-controller depends on into envtest
and registers the schema. manage tagging test added to exercise
the funcionality.
drewwells
commented
Jul 15, 2024
| var dbClaimList v1.DatabaseClaimList | ||
| if err := cli.List(ctx, &dbClaimList, client.MatchingFields{instanceLableKey: dbClaim.Spec.InstanceLabel}); err != nil { | ||
| if err := r.Client.List(ctx, &dbClaimList, client.MatchingFields{instanceLableKey: dbClaim.Spec.InstanceLabel}); err != nil { |
There was a problem hiding this comment.
Technically, this fieldkey index is no longer being tested. This was a really roundabout way to verify it though. If we think it deserves testing, a more clear test is suited here.
kd7lxl
approved these changes
Jul 15, 2024
|
|
||
| // CanTagResources checks if there's claims matching the instance | ||
| // label of the dbClaim. If there's only one claim, it can tag | ||
| func CanTagResources(ctx context.Context, dbClaimList v1.DatabaseClaimList, dbClaim v1.DatabaseClaim) (bool, error) { |
There was a problem hiding this comment.
We do not use the ctx, do we need to keep it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.