Fix #4390
Closed
Fix #4390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wouterdb
approved these changes
Jun 20, 2022
Contributor
Author
I know, has been added. |
Contributor
|
Processing this pull request |
inmantaci
pushed a commit
that referenced
this pull request
Jun 20, 2022
…ce will not always render (Issue inmanta/inmanta-sphinx#52, PR #4390) # Description Validated against build closes inmanta/inmanta-sphinx#52 # Self Check: Strike through any lines that are not applicable (`~~line~~`) then check the box - [ ] Attached issue to pull request - [ ] Changelog entry - [ ] Type annotations are present - [ ] Code is clear and sufficiently documented - [ ] No (preventable) type errors (check using make mypy or make mypy-diff) - [ ] Sufficient test cases (reproduces the bug/tests the requested feature) - [ ] Correct, in line with design - [ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: ) # Reviewer Checklist: - [ ] Sufficient test cases (reproduces the bug/tests the requested feature) - [ ] Code is clear and sufficiently documented - [ ] Correct, in line with design
Closed
inmantaci
pushed a commit
that referenced
this pull request
Jun 20, 2022
…ce will not always render (Issue inmanta/inmanta-sphinx#52, PR #4390) # Description Validated against build closes inmanta/inmanta-sphinx#52 # Self Check: Strike through any lines that are not applicable (`~~line~~`) then check the box - [ ] Attached issue to pull request - [ ] Changelog entry - [ ] Type annotations are present - [ ] Code is clear and sufficiently documented - [ ] No (preventable) type errors (check using make mypy or make mypy-diff) - [ ] Sufficient test cases (reproduces the bug/tests the requested feature) - [ ] Correct, in line with design - [ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: ) # Reviewer Checklist: - [ ] Sufficient test cases (reproduces the bug/tests the requested feature) - [ ] Code is clear and sufficiently documented - [ ] Correct, in line with design
Closed
Contributor
|
Merged into branches master in c3a6af9 |
Contributor
|
Processing #4397. |
inmantaci
pushed a commit
that referenced
this pull request
Jun 20, 2022
…ce will not always render (Issue inmanta/inmanta-sphinx#52, PR #4390) Pull request opened by the merge tool on behalf of #4390
Contributor
|
Processing #4396. |
FloLey
pushed a commit
that referenced
this pull request
Jun 22, 2022
…ce will not always render (Issue inmanta/inmanta-sphinx#52, PR #4390) # Description Validated against build closes inmanta/inmanta-sphinx#52 # Self Check: Strike through any lines that are not applicable (`~~line~~`) then check the box - [ ] Attached issue to pull request - [ ] Changelog entry - [ ] Type annotations are present - [ ] Code is clear and sufficiently documented - [ ] No (preventable) type errors (check using make mypy or make mypy-diff) - [ ] Sufficient test cases (reproduces the bug/tests the requested feature) - [ ] Correct, in line with design - [ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: ) # Reviewer Checklist: - [ ] Sufficient test cases (reproduces the bug/tests the requested feature) - [ ] Code is clear and sufficiently documented - [ ] Correct, in line with design
Contributor
|
Processing #4396. |
inmantaci
pushed a commit
that referenced
this pull request
Jun 22, 2022
…ce will not always render (Issue inmanta/inmanta-sphinx#52, PR #4390) Pull request opened by the merge tool on behalf of #4390
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Validated against build
closes inmanta/inmanta-sphinx#52
Self Check:
Strike through any lines that are not applicable (
~~line~~) then check the boxReviewer Checklist: