Add internal-server-address config option #9774
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanderr
approved these changes
Nov 25, 2025
|
|
||
| internal_server_address: Option[str] = Option( | ||
| "server", | ||
| "internal_server_address", |
Contributor
There was a problem hiding this comment.
Is "internal" an established term? It reads weird to me, and I would expect "local", but I don't really know anything about this domain, so this is far from a change request.
Contributor
Author
There was a problem hiding this comment.
"internal" seems to be the more common term for this. "private_ip" seems to be used too, but I like that less because it can be interpreted as an IP address that belongs to a private address range.
Contributor
|
I agree with your assessment on the test case. |
arnaudsjs
requested review from
Hugo-Inmanta
and removed request for
jptrindade
Hugo-Inmanta
approved these changes
Nov 26, 2025
Contributor
|
Processing this pull request |
inmantaci
pushed a commit
that referenced
this pull request
Nov 26, 2025
… PR #9774) # Description Added the `server.internal-server-address` config option. Should I add a test case for this? I don't really see how to do that in a useful way. closes #9761 # Self Check: - [x] Attached issue to pull request - [x] Changelog entry - [x] Type annotations are present - [x] Code is clear and sufficiently documented - [x] No (preventable) type errors (check using make mypy or make mypy-diff) - [ ] Sufficient test cases (reproduces the bug/tests the requested feature) - [x] Correct, in line with design - [x] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: ) - [ ] ~~If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see [test-fixes](https://internal.inmanta.com/development/core/tasks/build-master.html#test-fixes) for more info)~~
inmantaci
pushed a commit
that referenced
this pull request
Nov 26, 2025
… PR #9774) # Description Added the `server.internal-server-address` config option. Should I add a test case for this? I don't really see how to do that in a useful way. closes #9761 # Self Check: - [x] Attached issue to pull request - [x] Changelog entry - [x] Type annotations are present - [x] Code is clear and sufficiently documented - [x] No (preventable) type errors (check using make mypy or make mypy-diff) - [ ] Sufficient test cases (reproduces the bug/tests the requested feature) - [x] Correct, in line with design - [x] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: ) - [ ] ~~If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see [test-fixes](https://internal.inmanta.com/development/core/tasks/build-master.html#test-fixes) for more info)~~
Contributor
|
Merged into branches master in a3eeb14 |
Contributor
|
Processing #9789. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added the
server.internal-server-addressconfig option.Should I add a test case for this? I don't really see how to do that in a useful way.
closes #9761
Self Check:
If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see test-fixes for more info)