Skip to content
This repository was archived by the owner on Mar 10, 2026. It is now read-only.

feat(YouTube - Searchbar): Restyle#58

Merged
inotia00 merged 2 commits into
inotia00:revanced-extendedfrom
Francesco146:searchbar-rvx
Jun 27, 2024
Merged

feat(YouTube - Searchbar): Restyle#58
inotia00 merged 2 commits into
inotia00:revanced-extendedfrom
Francesco146:searchbar-rvx

Conversation

@Francesco146
Copy link
Copy Markdown

@ILoveOpenSourceApplications
Copy link
Copy Markdown

Can we have a screenshot of how it's going to look?

@Francesco146
Copy link
Copy Markdown
Author

Here's some screenshots

IMG_20240626_061744_979
IMG_20240626_061741_423
IMG_20240626_061736_668
IMG_20240626_061734_540

@Francesco146
Copy link
Copy Markdown
Author

to mimic yt instead of "Search settings" as text hint, we could put:

"Search {customName}"

from the patch options. So the result will be this:

"Search ReVanced Extended"

or

"Search FooBar" (if the user patched with Custom RVX Setting Name = FooBar

@ILoveOpenSourceApplications
Copy link
Copy Markdown

Do you think it's within the scope of this PR to resolve inotia00/ReVanced_Extended#2130?

@Francesco146
Copy link
Copy Markdown
Author

I'll work on that request, but I think it is better to divide the work into several steps. otherwise we wait more and more time without releasing anything new. to make the searchbar a different page, I need to study more how android development on views works.

so no, this PR will only have the restyle, the custom name in the text hint and the code suggestions that inotia will propose

@Rairof
Copy link
Copy Markdown

Rairof commented Jun 26, 2024

#58 (comment)
@Francesco146
it would be nice if you could consider adding the option to customize the pre-text inside the search bar (i.e "Search settings" in your screenshots) within patch option to user's choice similar to how we can change RVX settings name through its patch if it is possible.
I know this sounds similar to your comment in #58 (comment) but I was thinking on giving the users complete customization option on having whatever text in it rather then just being able to change Search(CustomName) in it.

@Francesco146
Copy link
Copy Markdown
Author

Francesco146 commented Jun 26, 2024

immagine

done, note that the current translated strings should be updated to match their YouTube language (in order to include the %s)


@Rairof in a new PR maybe

@inotia00
Copy link
Copy Markdown
Owner

Since I am not granted access to the PR branch, I will make changes manually after the merge

@inotia00 inotia00 merged commit f868c54 into inotia00:revanced-extended Jun 27, 2024
@Francesco146 Francesco146 deleted the searchbar-rvx branch July 1, 2024 16:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants