-
Notifications
You must be signed in to change notification settings - Fork 7
ADR: Total conversion functions' conventions #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
carbolymer
merged 1 commit into
main
from
mgalazyn/adr-use-inject-for-conversion-functions
Jun 9, 2025
Merged
ADR: Total conversion functions' conventions #74
carbolymer
merged 1 commit into
main
from
mgalazyn/adr-use-inject-for-conversion-functions
Jun 9, 2025
+118
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8fd1aea
to
1585086
Compare
Inject
draft00c20de
to
3444bbf
Compare
newhoggy
reviewed
May 21, 2025
newhoggy
reviewed
May 21, 2025
carbolymer
commented
May 21, 2025
newhoggy
reviewed
May 22, 2025
d39cbda
to
ea7ef24
Compare
d3d3831
to
756aef0
Compare
Jimbo4350
approved these changes
May 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but left two comments.
c9e8e94
to
31dd2a8
Compare
palas
approved these changes
May 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Looks good to me. I added a few suggestions and questions, mainly just for clarity
3 tasks
99f0054
to
c2ab418
Compare
c2ab418
to
8cb5335
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.