Skip to content

ADR: Total conversion functions' conventions #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2025

Conversation

carbolymer
Copy link
Collaborator

No description provided.

@carbolymer carbolymer self-assigned this May 7, 2025
@carbolymer carbolymer force-pushed the mgalazyn/adr-use-inject-for-conversion-functions branch 3 times, most recently from 8fd1aea to 1585086 Compare May 21, 2025 12:59
@carbolymer carbolymer changed the title Use Inject draft Total conversion functions naming convention May 21, 2025
@carbolymer carbolymer changed the title Total conversion functions naming convention Total conversion functions' naming convention May 21, 2025
@carbolymer carbolymer changed the title Total conversion functions' naming convention Total conversion functions' conventions May 21, 2025
@carbolymer carbolymer marked this pull request as ready for review May 21, 2025 13:00
@carbolymer carbolymer force-pushed the mgalazyn/adr-use-inject-for-conversion-functions branch 4 times, most recently from 00c20de to 3444bbf Compare May 21, 2025 13:05
@carbolymer carbolymer force-pushed the mgalazyn/adr-use-inject-for-conversion-functions branch 2 times, most recently from d39cbda to ea7ef24 Compare May 27, 2025 10:10
@carbolymer carbolymer requested a review from newhoggy May 27, 2025 10:11
@carbolymer carbolymer force-pushed the mgalazyn/adr-use-inject-for-conversion-functions branch 2 times, most recently from d3d3831 to 756aef0 Compare May 27, 2025 12:31
Copy link
Collaborator

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but left two comments.

@carbolymer carbolymer force-pushed the mgalazyn/adr-use-inject-for-conversion-functions branch 3 times, most recently from c9e8e94 to 31dd2a8 Compare May 27, 2025 13:28
Copy link
Collaborator

@palas palas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks good to me. I added a few suggestions and questions, mainly just for clarity

@carbolymer carbolymer force-pushed the mgalazyn/adr-use-inject-for-conversion-functions branch 3 times, most recently from 99f0054 to c2ab418 Compare June 9, 2025 10:10
@carbolymer carbolymer changed the title Total conversion functions' conventions ADR: Total conversion functions' conventions Jun 9, 2025
@carbolymer carbolymer force-pushed the mgalazyn/adr-use-inject-for-conversion-functions branch from c2ab418 to 8cb5335 Compare June 9, 2025 13:08
@carbolymer carbolymer merged commit 594ba8b into main Jun 9, 2025
1 check failed
@carbolymer carbolymer deleted the mgalazyn/adr-use-inject-for-conversion-functions branch June 9, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants