This repository was archived by the owner on Aug 18, 2020. It is now read-only.
[DEVOPS-999] explorer frontend: Replace @GITREV@ with actual rev#3386
Merged
Conversation
angerman
previously approved these changes
Aug 13, 2018
Contributor
angerman
left a comment
angerman
left a comment
There was a problem hiding this comment.
LGTM
Can we somehow do a post build check that verifies there are no placeholders left in the generated source?
This fix is for the release/1.3.1 branch -- where gitrev changes invalidate the build cache.
rvl
force-pushed
the
devops-999-explorer-gitrev-release-1.3.1
branch
from
87e82b2 to
359ae7e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Cardano explorer was showing
v. 0.2.0( @GITREV )in the footer.Linked issue
https://iohk.myjetbrains.com/youtrack/issue/DEVOPS-999
Type of change
Testing checklist
QA Steps