This repository was archived by the owner on Aug 18, 2020. It is now read-only.
[CBR-227] Remove legacy wallet layer#3395
Merged
Merged
Conversation
This was never used, and will never be used. That is unfortunate, but at this point won't change, and having the legacy layer makes it more awkward to modify the layer since we have to make modifications to a layer that is never actually used.
KtorZ
approved these changes
Aug 14, 2018
Contributor
KtorZ
left a comment
There was a problem hiding this comment.
Assuming that there are no changes from WalletLayer/Types.hs -> WalletLayer.hs beside the bracket functions that have been moved, LGTM 👍
Contributor
Author
|
Nope, there aren't :) Thanks! |
KtorZ
pushed a commit
that referenced
this pull request
Nov 9, 2018
[CBR-227] Remove legacy wallet layer
KtorZ
pushed a commit
to input-output-hk/cardano-wallet-legacy
that referenced
this pull request
Nov 9, 2018
…hk/remove-legacy-wallet-layer [CBR-227] Remove legacy wallet layer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was never used, and will never be used. That is unfortunate, but at this
point won't change, and having the legacy layer makes it more awkward to modify
the layer since we have to make modifications to a layer that is never actually
used.
Description
Linked issue
Type of change
Developer checklist
Testing checklist
QA Steps
Screenshots (if available)