This repository was archived by the owner on Aug 18, 2020. It is now read-only.
[CBR-207] Remove log warper dependency#3476
Merged
Merged
Conversation
5c9d7a8 to
a8a2f24
Compare
CodiePP
reviewed
Aug 24, 2018
| @@ -0,0 +1,23 @@ | |||
| module Pos.Util.Wlog | |||
Contributor
There was a problem hiding this comment.
this abstracts 'log-warper' such that the direct import of it in other cardano-sl modules can be removed.
7 tasks
a8a2f24 to
a69e401
Compare
a69e401 to
af5aa9a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In total 163 source code files import ‘System.Wlog’ directly from ‘log-warper’ and 16 modules in cardano-sl link to this library (as indicated in their cabals). We want to reduce the dependency on this external library.
As a first step we introduce module ‘Pos.Util.Wlog’ in ‘util’ that exports all of ‘System.Wlog’ and change the import statement in all 163 source files.
This way we can get rid of the direct dependency on ‘log-warper’ in ‘cardano-sl’ modules and only refer to it from module ‘util’.
Linked issue
https://iohk.myjetbrains.com/youtrack/issue/CBR-207
Type of change
Developer checklist
Testing checklist
QA Steps
Screenshots (if available)