This repository was archived by the owner on Aug 18, 2020. It is now read-only.
[CO-354] docs: add configuration info for "protocolMagic"#3583
Merged
Conversation
erikd
previously approved these changes
Sep 13, 2018
Member
erikd
left a comment
erikd
left a comment
There was a problem hiding this comment.
Seems legit but would be good to get confirmation from @mhuesch or @intricate as well.
disassembler
previously approved these changes
Sep 13, 2018
mhuesch
previously approved these changes
Sep 13, 2018
Contributor
mhuesch
left a comment
mhuesch
left a comment
There was a problem hiding this comment.
Looks good - just a minor and optional addition.
rvl
dismissed stale reviews from mhuesch, disassembler, and erikd
via
ac71936
rvl
force-pushed
the
co-354-network-magic-doc
branch
from
e1c07c4 to
ac71936
Compare
rvl
changed the title
rvl
changed the title
Contributor
Author
|
This doc update needs to be completely redone since the config layout for CO-354 changed. |
rvl
force-pushed
the
co-354-network-magic-doc
branch
from
ac71936 to
19aba59
Compare
rvl
changed the title
Contributor
Author
|
It's updated now, and can be merged into |
angerman
approved these changes
Oct 1, 2018
| that the protocol magic value will be included in the address | ||
| format and hence transactions. | ||
|
|
||
| * `dbSerializeVersion` — **TODO** |
Contributor
There was a problem hiding this comment.
Assuming this is "ok" to be left here; as there was a TODO in there before as well.
Contributor
Author
There was a problem hiding this comment.
Yep, that's the only other setting in the core section, and I'm not sure what it does.
cleverca22
approved these changes
Oct 1, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update configuration docs for
protocolMagic/requiresNetworkMagic.Linked issue
https://iohk.myjetbrains.com/youtrack/issue/CO-354