This repository was archived by the owner on Aug 18, 2020. It is now read-only.
[CO-371] Refactor launchers #3605
Merged
Merged
Conversation
Also giving the launching function a bit more power to actually be self-sufficient. This way, it becomes really a function that help us parse the CLI arguments and start-up a node, passing it resources acquired or allocated along the way. This is especially useful to reduce duplications which occurs in the wallet launchers and, that will soon otherwise occur in the integration tests and demo code.
Contributor
Author
|
Thanks @erikd. I wasn't expecting a review before Monday ^^ |
Contributor
|
..and I wasn't expecting my PR to go into conflict due to changes over the weekend |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Working towards acceptance criteria CO-356.1 & CO-356.5, this task would make it easy to start-up a node without much knowledge or manipulation of the internals. Starting a node should be as easy as providing a bunch of configuration parameters coming from a CLI.
Also, these bits of code are currently duplicated between the
lib@node/Main.hscode andwallet-new@server/Main.hs, and similar things are needed in the incoming integration tests and demo.This PR removes this duplication and unify the way nodes are launched 👍
Starting a node becomes as simple as:
Linked issue
[CO-371]
Type of change
Developer checklist
[ ] CHANGELOG entry has been added and is linked to the correct PR on GitHub.Testing checklist
[ ] I have added tests to cover my changes.QA Steps
Screenshots (if available)