This repository was archived by the owner on Aug 18, 2020. It is now read-only.
[CO-386] Separate and expose wallet actions#3608
Merged
Merged
Conversation
The action exposed there are necessary for someone which want to start a wallet node from haskell. They're currently part of the server/Main.hs which is an executable, making it impossible to be imported by another module. This commits extract them from 'server/Main.hs' making them easy to re-use and/or remove!
adinapoli-iohk
approved these changes
Sep 17, 2018
Contributor
adinapoli-iohk
left a comment
adinapoli-iohk
left a comment
There was a problem hiding this comment.
LGTM, this is literally just code reshuffling.
Contributor
Author
|
Wallet integration tests still fail because tests are broken (currently being worked on). However, the wallet can still start correctly as expected. So merging this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The action exposed there are necessary for someone who wants to start a
wallet node from haskell (like in the
integration-testsfor instance ... ). They're currently part of the server/Main.hswhich is an executable, making it impossible to be imported by another
module. This commits extract them from 'server/Main.hs' making them
easy to re-use and/or remove!
Linked issue
[CO-386]
Type of change
Developer checklist
[ ] CHANGELOG entry has been added and is linked to the correct PR on GitHub.Testing checklist
[ ] I have added tests to cover my changes.QA Steps
Screenshots (if available)