This repository was archived by the owner on Aug 18, 2020. It is now read-only.
[CO-410] Introduce NetworkMagic#3733
Merged
Merged
Conversation
intricate
force-pushed
the
i+m/develop/CO-410/introduce-networkmagic
branch
5 times, most recently
from
fb7ae41 to
b16ec48
Compare
intricate
changed the title
7 tasks
Jimbo4350
force-pushed
the
i+m/develop/CO-410/introduce-networkmagic
branch
from
b16ec48 to
b3d6ed2
Compare
mhuesch
suggested changes
Oct 16, 2018
Contributor
mhuesch
left a comment
mhuesch
left a comment
There was a problem hiding this comment.
Looks good overall. We should remove those TODOs. The other comments are optional.
What's up with wallet/test/wallet-db-1.1.1/open.lock? It seems it was added as a 0-line file in this PR.
Jimbo4350
force-pushed
the
i+m/develop/CO-410/introduce-networkmagic
branch
2 times, most recently
from
b3d6ed2 to
c68365e
Compare
intricate
force-pushed
the
i+m/develop/CO-410/introduce-networkmagic
branch
3 times, most recently
from
67b594b to
834ac93
Compare
mhuesch
approved these changes
Oct 16, 2018
erikd
approved these changes
Oct 17, 2018
erikd
force-pushed
the
i+m/develop/CO-410/introduce-networkmagic
branch
from
834ac93 to
8e0a035
Compare
erikd
force-pushed
the
i+m/develop/CO-410/introduce-networkmagic
branch
from
8e0a035 to
10483c1
Compare
Member
|
Hydra seemed to have screwed up the building of this PR so I rebased this and force pushed. |
Contributor
|
Merging before any conflicts arise! |
KtorZ
pushed a commit
that referenced
this pull request
Nov 9, 2018
…oduce-networkmagic [CO-410] Introduce NetworkMagic
KtorZ
pushed a commit
to input-output-hk/cardano-wallet-legacy
that referenced
this pull request
Nov 9, 2018
…hk/i+m/develop/CO-410/introduce-networkmagic [CO-410] Introduce NetworkMagic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Building on the previous PR (#3715), we add the
NetworkMagicdatatype, which allows us to discriminate addresses originating from different networks.In order to make this commit as simple and easy-to-review as possible, I stub out the added arguments of type
NetworkMagicwith a dummy variable:fixedNM. This puts off the (fairly involved) work of threadingNetworkMagicvalues from the nearest occurrence ofProtocolMagicto where said values are needed.The remainder of the work will come in a separate commit.
Linked issue
https://iohk.myjetbrains.com/youtrack/issue/CO-410
Type of change
Developer checklist
^ there is no 1.3.1 section in the CHANGELOG, and this is dev work on a release branch, so I'm skipping this.
Testing checklist
^ no tests were added because these changes introduce new capabilities which are not used yet. Thus the behavior is the same, and the existing tests should be adequate.