Skip to content
This repository was archived by the owner on Aug 18, 2020. It is now read-only.

Exorcise cardano-report-server#4194

Merged
iohk-bors[bot] merged 2 commits into
developfrom
erikd/report-server-exorcisim
Jul 16, 2019
Merged

Exorcise cardano-report-server#4194
iohk-bors[bot] merged 2 commits into
developfrom
erikd/report-server-exorcisim

Conversation

@erikd
Copy link
Copy Markdown
Member

@erikd erikd commented Jul 16, 2019

Devops disabled the server these reports were uploaded to some time
ago so we can remove this from the node. Doing this will make
building cardano-byron-proxy easier.

Devops disabled the server these reports were uploaded to some time
ago so we can remove this from the node. Doing this will make
building cardano-byron-proxy easier.
@erikd erikd requested review from cleverca22, disassembler and rvl July 16, 2019 06:02
Copy link
Copy Markdown
Contributor

@deepfire deepfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks lovely!

@deepfire
Copy link
Copy Markdown
Contributor

bors r+

1 similar comment
@erikd
Copy link
Copy Markdown
Member Author

erikd commented Jul 16, 2019

bors r+

@iohk-bors
Copy link
Copy Markdown
Contributor

iohk-bors Bot commented Jul 16, 2019

Already running a review

iohk-bors Bot added a commit that referenced this pull request Jul 16, 2019
4194: Exorcise cardano-report-server r=deepfire a=erikd

Devops disabled the server these reports were uploaded to some time
ago so we can remove this from the node. Doing this will make
building cardano-byron-proxy easier.


Co-authored-by: Erik de Castro Lopo <erikd@mega-nerd.com>
@iohk-bors
Copy link
Copy Markdown
Contributor

iohk-bors Bot commented Jul 16, 2019

Build failed

Copy link
Copy Markdown
Contributor

@dcoutts dcoutts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@erikd
Copy link
Copy Markdown
Member Author

erikd commented Jul 16, 2019

bors r+

iohk-bors Bot added a commit that referenced this pull request Jul 16, 2019
4194: Exorcise cardano-report-server r=erikd a=erikd

Devops disabled the server these reports were uploaded to some time
ago so we can remove this from the node. Doing this will make
building cardano-byron-proxy easier.


Co-authored-by: Erik de Castro Lopo <erikd@mega-nerd.com>
@iohk-bors
Copy link
Copy Markdown
Contributor

iohk-bors Bot commented Jul 16, 2019

@iohk-bors iohk-bors Bot merged commit 5e50f6e into develop Jul 16, 2019
@iohk-bors iohk-bors Bot deleted the erikd/report-server-exorcisim branch July 16, 2019 21:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants