Draft
Conversation
Soupstraw
force-pushed
the
jj/map-gen-fix
branch
2 times, most recently
from
44beb10 to
173b184
Compare
Extract genAndValidateRule and genAndValidateCddl from genAndValidateFromFile to enable reuse for testing Huddle schemas. Add "Generated value validates" tests that verify generated CBOR values pass validation. This exposes a bug in optionalMapExample where the generator cannot reliably produce 10 unique keys from a 10-element range (1..10), causing most generated maps to have fewer than the required 10 entries. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The generator cannot reliably produce unique keys for maps where the key range size equals the required entry count. This will be addressed in a separate PR. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Fix Word64 underflow in OIBounded bounds decrementing by using saturating subtraction (clampedPred) instead of regular subtraction - Fix KV case to continue processing remaining nodes instead of returning early - Use max 0 sz in frequency to handle negative sizes - Add proper error message for map generation failure Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Soupstraw
force-pushed
the
jj/map-gen-fix
branch
from
2461613 to
8898980
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #155