[LW-12241] Update index.ts to cater for the cleardown of ledger state if not alr… #3276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eady flagged as done Update index.ts to cater for the cleardown of ledger state if not already flagged as done
Collaborator
Author
|
I have applied the moving of the imports and the build was as clean as it was before changes applied |
hegaleon
force-pushed
the
chore/LW-12241-ledger-state-clean-v10
branch
from
c3508e0 to
4e7f3b0
Compare
Co-authored-by: Szymon Masłowski <[email protected]>
szymonmaslowski
requested changes
Feb 18, 2025
source/main/index.ts
Outdated
|
|
||
| // Check if the flag file exists | ||
| if (fs.existsSync(flagFileLongName)) { | ||
| logger.log(`${flagFileLongName} found. NoHskpg.`); |
Contributor
There was a problem hiding this comment.
It seems there is no log method on logger. Please use info instead.
Suggested change
| logger.log(`${flagFileLongName} found. NoHskpg.`); | |
| logger.info(`${flagFileLongName} found. NoHskpg.`); |
source/main/index.ts
Outdated
| if (fs.lstatSync(filePath).isFile()) { | ||
| // ?it's a file | ||
| fs.unlinkSync(filePath); | ||
| console.log(`HskpgDone: ${filePath}`); |
Contributor
There was a problem hiding this comment.
Suggested change
| console.log(`HskpgDone: ${filePath}`); | |
| logger.info(`HskpgDone: ${filePath}`); |
source/main/index.ts
Outdated
| // Create v10-upgraded completed marker | ||
| fs.writeFileSync(flagFileLongName, 'HskpgNwFlag'); | ||
| } catch (err) { | ||
| console.error(`Error removing files: ${err}`); |
Contributor
There was a problem hiding this comment.
Suggested change
| console.error(`Error removing files: ${err}`); | |
| logger.error(`Error removing files: ${err}`); |
Collaborator
Author
There was a problem hiding this comment.
I have applied those changes and committed
przemyslaw-wlodek
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LW-12241
Code Changes
Update index.ts to cater for the cleardown of ledger state if not already flagged as done, this involved creating a routine for the cleardown, creating a flag indicating it was completed
check if v10 state clear flag created
if not the remove files under chain/ledger
create non-reentrant flag
Todos
Screenshots
Testing Checklist
Review Checklist
Basics
input-output-hk/daedalus-devandinput-output-hk/daedalus-qaassigned as PR reviewersrelease-vNext,feature/bug/chore,WIP)yarn manage:translationsproduces no changes)yarn storybook)yarn.lockfile is updatedCode Quality
Testing
After Review