[ifd] cabalProjectToNix #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hamishmack I'll try to write a testcase for this as well. I've cut out quite a bit though. |
hamishmack
reviewed
May 14, 2019
Closed
angerman
force-pushed
the
angerman/hackage-index
branch
from
dc6bb5c to
77c9696
Compare
- remove recentNixpkgs (this should rely on the provided (pinned) nixpkgs only. - parameterize callProjectToNix over the indexState. This prevents us from pulling it through the arguments and inheriting it evrywhere. - keep hackage as the one from the hackageSourceJSON. The reason being that we want a consistent hackage, and we periodically update it. As such having a second way to generate this will increase the compexity of haskell.nix. The indexState will almost always be behind the upstream hackageSourceJSON and as such generating the hackage nix expressions over just updating the hackageSourceJSON seems less beneficial.
angerman
force-pushed
the
angerman/hackage-index
branch
from
77c9696 to
1ecd24e
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extracts the
cabalProjectToNixfunction from #120 and trims the logic substantially.